Fix display long title without spaces in DocumentCardTitle#4414
Merged
mikewheaton merged 2 commits intomicrosoft:masterfrom Apr 2, 2018
qianghuang1:master
Merged
Fix display long title without spaces in DocumentCardTitle#4414mikewheaton merged 2 commits intomicrosoft:masterfrom qianghuang1:master
mikewheaton merged 2 commits intomicrosoft:masterfrom
qianghuang1:master
Conversation
Contributor
Author
|
Hi @mikewheaton and @yiminwu , recently we faced an issue that described above. We thought anyone that using the class "ms-DocumentCard-details" would face the same issue. Plz help to review the PR, i will add change file next Monday. |
mikewheaton
approved these changes
Mar 30, 2018
Contributor
Author
|
@mikewheaton @yiminwu Could anyone help to merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
will add npm run change later
Addresses an issue:
Example like https://github.com/OfficeDev/office-ui-fabric-react/blob/d4159b20c9b143248cf52d1f3cdda24fd2e1caae/packages/office-ui-fabric-react/src/components/DocumentCard/examples/DocumentCard.Compact.Example.tsx#L71
When the title is too long and without spaces, the document card will be like
Description of changes
Give the .ms-DocumentCard-details the overflow:hidden.