Skip to content

Add Office Add-ins toolkit#4443

Merged
jordandrako merged 5 commits intomicrosoft:masterfrom
jordandrako:office-addins-toolkit
Apr 4, 2018
Merged

Add Office Add-ins toolkit#4443
jordandrako merged 5 commits intomicrosoft:masterfrom
jordandrako:office-addins-toolkit

Conversation

@jordandrako
Copy link
Copy Markdown
Contributor

@jordandrako jordandrako commented Apr 3, 2018

Pull request checklist

  • Include a change request file using $ npm run change

Description of changes

  • Add Office Add-ins Toolkit blurb and XD doc aka.ms link. (Waiting on Fabric CDN pr to merge)
  • Update Fabric Design Toolkit link to aka.ms

Focus areas to test

Copy-pasted text, so grammar?

@jordandrako jordandrako requested review from Jahnp and lynamemi April 3, 2018 18:01
@jordandrako jordandrako changed the title Add Office Add-ins toolkit Don't merge yet: Add Office Add-ins toolkit Apr 3, 2018
@jordandrako
Copy link
Copy Markdown
Contributor Author

@jordandrako jordandrako changed the title Don't merge yet: Add Office Add-ins toolkit Add Office Add-ins toolkit Apr 4, 2018
@jordandrako
Copy link
Copy Markdown
Contributor Author

jordandrako commented Apr 4, 2018

@lynamemi @Jahnp The file is merged but at the time of this comment, this link doesn't return the zip file.
https://static2.sharepointonline.com/files/fabric/fabric-website/files/addins_toolkit.zip

Is this a propagation issue or is the link wrong?

@jordandrako
Copy link
Copy Markdown
Contributor Author

Alright the build finished so the link works now :) Ready for review/approval!

<li><a className={ styles.relatedLink } href='https://static2.sharepointonline.com/files/fabric/fabric-website/files/sharepoint_toolkit.zip'>SharePoint XD Toolkit</a></li>
</ul>

<h3>Office Add-ins Toolkit</h3>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have 'Design' in the other two titles, maybe this should read 'Office Add-ins Design Toolkit' ?

</ul>

<h3>Office Add-ins Toolkit</h3>
<p>The Add-in design toolkit provides layouts for interface elements and commonly used UX patterns in Word, Excel, and PowerPoint. Use it together with the Fabric design toolkit to create an add-in that fits seamlessly with Office.</p>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nit: add 's' to Add-in(s) - I'm seeing it plural everywhere else.

Copy link
Copy Markdown
Collaborator

@lynamemi lynamemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nit comments based on feedback I got when I added these toolkits originally. @Jahnp may agree/disagree.

@jordandrako
Copy link
Copy Markdown
Contributor Author

I agree.

@jordandrako jordandrako merged commit d81862b into microsoft:master Apr 4, 2018
@jordandrako jordandrako deleted the office-addins-toolkit branch April 4, 2018 20:37
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants