ComponentRef values should use public interfaces#4427
Merged
dzearing merged 2 commits intomicrosoft:masterfrom Apr 11, 2018
dzearing:refs
Merged
ComponentRef values should use public interfaces#4427dzearing merged 2 commits intomicrosoft:masterfrom dzearing:refs
dzearing merged 2 commits intomicrosoft:masterfrom
dzearing:refs
Conversation
dzearing
requested review from
Jahnp,
atneik,
cschleiden,
joschect and
micahgodbolt
as code owners
cschleiden
approved these changes
Apr 2, 2018
joschect
approved these changes
Apr 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the change to
componentRefsome of the typings were still component typings rather than their public interfaces. Fixed a bunch of them.