Skip to content

Add Button override to PageMarkdown.#4418

Merged
jordandrako merged 2 commits intomicrosoft:masterfrom
jordandrako:md2jsx-overrides
Apr 10, 2018
Merged

Add Button override to PageMarkdown.#4418
jordandrako merged 2 commits intomicrosoft:masterfrom
jordandrako:md2jsx-overrides

Conversation

@jordandrako
Copy link
Copy Markdown
Contributor

@jordandrako jordandrako commented Mar 30, 2018

Pull request checklist

  • Include a change request file using $ npm run change

Description of changes

If there is a <button> tag in md files, use DefaultButton. This allows props like primary as well.

@jordandrako jordandrako requested a review from dzearing March 30, 2018 21:46
@jordandrako jordandrako changed the title Add Button override the PageMarkdown. Add Button override to PageMarkdown. Mar 30, 2018
component: Image
},
button: {
component: DefaultButton
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change file or it doesn't get published

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed change file

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dzearing bump

@jordandrako jordandrako merged commit 71366a7 into microsoft:master Apr 10, 2018
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants