Align Tiles in last row with previous row#4407
Merged
ThomasMichon merged 4 commits intomicrosoft:masterfrom Apr 4, 2018
Merged
Align Tiles in last row with previous row#4407ThomasMichon merged 4 commits intomicrosoft:masterfrom
ThomasMichon merged 4 commits intomicrosoft:masterfrom
Conversation
Collaborator
|
Sounds like a nice polish! Can you post before and after screenshots? |
lynamemi
reviewed
Apr 4, 2018
Collaborator
lynamemi
left a comment
lynamemi
left a comment
There was a problem hiding this comment.
Looks good to me. Could you add some comments to TilesList describing your phantom tile strategy?
ThomasMichon
force-pushed
the
tiles-alignment
branch
from
3578471 to
0537696
Compare
lynamemi
approved these changes
Apr 4, 2018
Collaborator
lynamemi
left a comment
lynamemi
left a comment
There was a problem hiding this comment.
Great comments, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This change adds an elegant alignment behavior to
TilesListto make regular grids look better.If there are fewer tiles in the last row of a grid than are needed to fill the row, 'phantom' tiles are computed with an average width of the current tiles in the row until the row is 'full'. Then a new scale factor is selected based on the addition of the phantom tiles. The effect is that tiles in the last row will tend to line up with tiles above them, if the tiles all have the same size.
Before:
After: