Variants: improve strong variant generation algorithm to better handle inversion#4420
Merged
dzearing merged 6 commits intomicrosoft:masterfrom Apr 2, 2018
Merged
Variants: improve strong variant generation algorithm to better handle inversion#4420dzearing merged 6 commits intomicrosoft:masterfrom
dzearing merged 6 commits intomicrosoft:masterfrom
Conversation
dzearing
approved these changes
Mar 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
The strong variant is unique in that it is an inverse of the base theme. If the base theme has a light background, the strong variant has a dark background, and vice versa. The algorithm should not use ANY slots from the original theme as defaults, because the inversion will cause accessibility issues. Instead, only use new slots in the strong variant, forcing regeneration of all semantic slots.
Focus areas to test
(optional)