Pickers: Fix some bugs related to scrolling and focus#4416
Merged
joschect merged 8 commits intomicrosoft:masterfrom Mar 30, 2018
Merged
Pickers: Fix some bugs related to scrolling and focus#4416joschect merged 8 commits intomicrosoft:masterfrom
joschect merged 8 commits intomicrosoft:masterfrom
Conversation
amyngu
approved these changes
Mar 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
There were two bugs related to pickers and suggestions.
The first was when a user scrolled and attempted to click on a suggestion, the suggestions would jump back to the top of the list and not select the item clicked.
The second bug was that the suggestions menu would not dismiss properly when a suggestion was selected.
This additionally cleans up focus so focus events are only called when focus leaves the component as a whole, not just when focus leaves the picker input.
Focus areas to test
(optional)