Merged
Conversation
Vitalius1
changed the title
added 2 commits
April 6, 2018 15:56
dzearing
reviewed
Apr 9, 2018
| } | ||
|
|
||
| const SIZES: { | ||
| export const SIZES: { |
Member
There was a problem hiding this comment.
instead of exporting "SIZES", can you rename this to something specific to tile, and use TitleCasing?
TileLayoutSizes would be reasonable.
Member
There was a problem hiding this comment.
Think of it like this: When you import {} from '@uifabric/experiments'; the intellisense will suggest importing SIZES. Does that make sense to the caller?
Contributor
Author
There was a problem hiding this comment.
Got it. Thanks for the feedback. I guess if you are putting it in the context of intellisense when importing makes total sense.
dzearing
approved these changes
Apr 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Exports an enum to use the values to create a PlaceholderTile component as an element in Shimmer component.
If values change in future the PlaceholderTile will be also using them.
Focus areas to test
(optional)