Add quality scale file to Ness Alarm by Poshy163 · Pull Request #163425 · home-assistant/core

Poshy163 · 2026-02-19T03:05:24Z

Proposed change

Push Ness Alarm to Bronze quality scale, to align with the integration gaining config flow support

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2026-02-19T03:05:31Z

Hey there @nickw444, mind taking a look at this pull request as it has been labeled with an integration (ness_alarm) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ness_alarm can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign ness_alarm Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot

Pull request overview

This PR updates the ness_alarm integration to align with the Integration Quality Scale by moving it from legacy to Bronze, now that it has config flow support.

Changes:

Set ness_alarm’s manifest.json quality scale to bronze and add a new quality_scale.yaml tracker file.
Update ness_alarm entities to use has_entity_name (avoiding duplicated device/entity naming).
Update hassfest quality-scale bookkeeping to stop treating ness_alarm as lacking quality scale metadata.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`script/hassfest/quality_scale.py`	Removes `ness_alarm` from hassfest lists for integrations missing quality scale information/files.
`homeassistant/components/ness_alarm/quality_scale.yaml`	Adds the integration quality scale rule status file needed for Bronze.
`homeassistant/components/ness_alarm/manifest.json`	Switches declared quality scale from `legacy` to `bronze`.
`homeassistant/components/ness_alarm/binary_sensor.py`	Enables `has_entity_name` and removes explicit entity name for zones.
`homeassistant/components/ness_alarm/alarm_control_panel.py`	Enables `has_entity_name` and removes explicit entity name for the panel.

joostlek

Can we add the quality scale first without code changes?

home-assistant · 2026-02-19T13:23:42Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Poshy163 · 2026-02-19T13:32:10Z

can do

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

joostlek

Let's put the things we agree on fixing in the comments in the YAML file and merge it, we can improve from there

joostlek · 2026-02-19T16:12:12Z

+  unique-config-entry: done
+
+  # Silver
+  action-exceptions: done


arming or disarming the alarm is also considered an action

We don't really do error handling for those, so is this true?

joostlek · 2026-02-19T16:13:46Z

@@ -0,0 +1,66 @@
+rules:


async_at_started should be wrapped in entry.async_on_unload

joostlek · 2026-02-19T16:14:36Z

@@ -0,0 +1,66 @@
+rules:


Why do we actually iterate twice over all the subentries in binary sensor setup?

joostlek · 2026-02-19T16:15:02Z

+  test-coverage: todo
+
+  # Gold
+  devices: done


You can link the binary sensor to the main device via via_device

joostlek · 2026-02-19T16:15:28Z

@@ -0,0 +1,66 @@
+rules:


Currently the binary sensor is always initalized with False, should that be None as we don't know the state yet?

joostlek · 2026-02-19T16:18:37Z

+  log-when-unavailable: todo
+  parallel-updates: todo
+  reauthentication-flow: todo
+  test-coverage: todo


I think I would recommend to switch from that MockClient to a proper mock where we just use AsyncMocks

joostlek · 2026-02-19T16:19:07Z

+  log-when-unavailable: todo
+  parallel-updates: todo
+  reauthentication-flow: todo
+  test-coverage: todo


More tests in the test_init.py can use mock_config_entry

joostlek · 2026-02-19T16:19:33Z

+  docs-removal-instructions: done
+  entity-event-setup: done
+  entity-unique-id: done
+  has-entity-name: done


Suggested change

has-entity-name: done

has-entity-name: todo

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>

Poshy163 · 2026-02-19T23:48:55Z

Seems like hassfest checks will just complain about it not being bronze or higher while having a quality scale file (and there doesnt seem to be any way around it)

New integrations are required to at least reach the Bronze tier.

ill keep this in a draft state till the required changes to make bronze pass

Poshy163 · 2026-02-20T00:27:06Z

i may as well just reintroduce the bare-minimum code improvements to hit bronze in the same PR at this point 🤷🏻

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

joostlek

Please make sure that the initial PR only has the yaml file. We can fix the rest later (hence I asked to put all the things we're going to fix in the comments inside of the file)

joostlek · 2026-03-12T18:25:54Z

+  unique-config-entry: done
+
+  # Silver
+  action-exceptions: done


We don't really do error handling for those, so is this true?

Bump aiotankerkoenig to 0.5.3 (home-assistant#170224) Fix entities refresh for UptimeRobot (home-assistant#170217) Update easyEnergy exception and icon translations (home-assistant#170218) Add more Gen1 sensors to indevolt (home-assistant#170191) Bump letpot to 0.7.0 (home-assistant#169868) Migrate Thermo Beacon to config entry runtime data (home-assistant#170226) Migrate Sensirion BLE to config entry runtime data (home-assistant#170227) Co-authored-by: Josef Zweck <josef@zweck.dev> Bump imgw-pib to 2.1.2 (home-assistant#170274) Bump serialx to 1.7.2 (home-assistant#170272) Bump aioamazondevices to 13.5.0 (home-assistant#170258) Update upb-lib to 0.7.0 (home-assistant#170051) Bump qbittorrent-api to 2026.5.1 (home-assistant#170181) Use VERSION from PrusaLinkConfigFlow in prusalink (home-assistant#170200) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Migrate Duco to python-duco-connectivity and remove temperature sensors (home-assistant#170237) fix: Do not forget segments from state when a new config arrives (home-assistant#170265) Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Complete icon translations for Indevolt (home-assistant#170292) Align Indevolt quality scale with documentation (home-assistant#170289) Apply strict typing to Indevolt integration (home-assistant#170288) iaqualink: set system specific polling interval (home-assistant#170279) Use standby for HDMI-CEC turn off (home-assistant#170206) prusalink: add continue-job button for ATTENTION state (home-assistant#170193) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> data grand lyon: implement diagnostics (home-assistant#170184) Set serial port description from `description`, not `product` (home-assistant#170160) Co-authored-by: Paulus Schoutsen <balloob@gmail.com> Update infrared-protocols to 4.0.0 (home-assistant#170297) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> data grand lyon: use test fixture instead of manual patching (home-assistant#170294) Handle empty BSB-LAN heating circuits (home-assistant#170249) Add diagnostics platform to Home Assistant Connect ZBT-2 (home-assistant#170158) Fix deprecated_class to work with inheritance (home-assistant#170137) Skip offline devices instead of aborting ViCare diagnostics (home-assistant#170106) Fix local API incorrectly marking devices as unavailable in Overkiz (home-assistant#170118) Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io> Add RepairsFlowResult TypeAlias (home-assistant#170263) Fix flaky diagnostics test for Novy Cooker Hood (home-assistant#170299) Fix spelling of RS-232 in Denon RS-232 integration (home-assistant#170298) data grand lyon: implement reconfiguration flow (home-assistant#170210) Add shared test mocks for the Infrared integration (home-assistant#170296) Co-authored-by: Claude <noreply@anthropic.com> Bump renault-api to 0.5.8 (home-assistant#170309) Bump indevolt api to 1.7.2 (home-assistant#170310) Update IQS to platinum for UptimeRobot (home-assistant#170260) Add player specific sensor to nintendo_parental_controls (home-assistant#155786) Co-authored-by: Joshua Peisach (ItzSwirlz) <itzswirlz2020@outlook.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Erik Montnemery <erik@montnemery.com> Fix hassio.backup_partial AttributeError when folders are specified (home-assistant#170312) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Add backoff to forbidden packages (home-assistant#170242) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Add tuya water timer data points (home-assistant#170314) Add more entities for Tuya camera (home-assistant#169966) Co-authored-by: mik-laj <12058428+mik-laj@users.noreply.github.com> Co-authored-by: Norbert Rittel <norbert@rittel.de> Add Tuya DLQ fixture (home-assistant#169585) Update rf-protocols to 3.0.0 (home-assistant#170301) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Add Message Expire Interval option to MQTT publish service (home-assistant#169317) Co-authored-by: Copilot <copilot@github.com> Add new CentriConnect component (home-assistant#166933) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Watts: add HVAC action + preset mode (home-assistant#169546) Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Joostlek <joostlek@outlook.com> Add quality scale for airnow integration (home-assistant#169709) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Fix nobo_hub NoboProfileSelector class-level mutable defaults (home-assistant#170119) Add cover support to control4 (home-assistant#169417) Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> Add Mitsubishi brand (home-assistant#169924) Co-authored-by: Nikolai Rahimi <nikolairahimi@users.noreply.github.com> Co-authored-by: Paulus Schoutsen <balloob@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Fix coordinator data mutation in YouTube diagnostics (home-assistant#170300) Co-authored-by: FIls0010 <a1867444@adelaide.edu.au> Bump aiovodafone to 3.2.0 (home-assistant#170322) Add countdown number for Tuya sfkzq single-valve timers (home-assistant#170318) Allow setting hvac_mode in generic_thermostat.set_temperature (home-assistant#168062) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> Z-Wave.me: Allow updating entities (home-assistant#167839) Fix MQTT device discovery not using shared QoS and encoding options (home-assistant#170195) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Google assistant temperature setting active thermostat mode (home-assistant#166448) Co-authored-by: Lucas Sanchez Sagrado <lucas.sansag@educa.jcyl.es> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Add quality scale to Tesla Fleet integration (home-assistant#160475) Co-authored-by: Claude <noreply@anthropic.com> Only use SmartThings switch for light if it should (home-assistant#166424) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Add quality scale file to Ness Alarm (home-assistant#163425) Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> Fix Shelly media player availability (home-assistant#170319) Update discovery description wording (home-assistant#170325) Bump teltasync to 0.3.0, fix discovery for older devices (home-assistant#169660) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Complete exception translations for Indevolt (home-assistant#170291) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Add Kiosker switch platform (home-assistant#168858) Add `ZWaveNodeBaseEntity` for Z-Wave node-level entities (home-assistant#170124) Add number platform to eurotronic_cometblue (home-assistant#168119) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>

Add changes required to push it to bronze

f5e972a

Poshy163 requested a review from a team as a code owner February 19, 2026 03:05

Copilot AI review requested due to automatic review settings February 19, 2026 03:05

home-assistant Bot added cla-signed code-quality integration: ness_alarm quality-scale by-code-owner Quality Scale: legacy labels Feb 19, 2026

Poshy163 mentioned this pull request Feb 19, 2026

Change quality scale from legacy to bronze home-assistant/home-assistant.io#43620

Closed

8 tasks

Copilot started reviewing on behalf of Poshy163 February 19, 2026 03:05 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

joostlek requested changes Feb 19, 2026

View reviewed changes

home-assistant Bot marked this pull request as draft February 19, 2026 13:23

Poshy163 added 2 commits February 20, 2026 00:03

revert code changes for alarm control panel

3ba9c39

revert code changes for binary sensor

5b4affb

Poshy163 marked this pull request as ready for review February 19, 2026 13:34

Copilot AI review requested due to automatic review settings February 19, 2026 13:34

home-assistant Bot requested a review from joostlek February 19, 2026 13:34

Copilot started reviewing on behalf of Poshy163 February 19, 2026 13:35 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

Comment thread homeassistant/components/ness_alarm/quality_scale.yaml

Comment thread homeassistant/components/ness_alarm/manifest.json Outdated

joostlek requested changes Feb 19, 2026

View reviewed changes

home-assistant Bot marked this pull request as draft February 19, 2026 16:20

Poshy163 and others added 2 commits February 20, 2026 10:01

Update script/hassfest/quality_scale.py

cd94007

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>

Update homeassistant/components/ness_alarm/manifest.json

574027c

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>

re-introduced bare-minimum code for the requirements to hit bronze

743d84c

Poshy163 marked this pull request as ready for review February 20, 2026 00:31

Copilot AI review requested due to automatic review settings February 20, 2026 00:31

home-assistant Bot requested a review from joostlek February 20, 2026 00:31

Copilot started reviewing on behalf of Poshy163 February 20, 2026 00:32 View session

update quality scale with feedback for future

976d535

Copilot AI reviewed Feb 20, 2026

View reviewed changes

joostlek requested changes Mar 12, 2026

View reviewed changes

home-assistant Bot marked this pull request as draft March 12, 2026 18:26

Poshy163 added 3 commits March 12, 2026 23:42

Limit Ness Alarm bronze PR to quality_scale.yaml

1ff218c

Revert ness_alarm init code change

e6d5bef

revert regression

9d02939

Poshy163 changed the title ~~Bring Ness Alarm to Bronze quality scale~~ Add quality scale file to Ness Alarm Mar 12, 2026

Poshy163 marked this pull request as ready for review March 12, 2026 23:50

Copilot AI review requested due to automatic review settings March 12, 2026 23:50

home-assistant Bot requested review from joostlek and removed request for Copilot March 12, 2026 23:50

joostlek approved these changes May 11, 2026

View reviewed changes

joostlek merged commit 0772034 into home-assistant:dev May 11, 2026
33 checks passed

lmaertin pushed a commit to lmaertin/homeassistant-core that referenced this pull request May 11, 2026

Add quality scale file to Ness Alarm (home-assistant#163425)

4ef2611

Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>

github-actions Bot locked and limited conversation to collaborators May 12, 2026

Uh oh!

Conversation

Poshy163 commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant Bot commented Feb 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

joostlek left a comment

Choose a reason for hiding this comment

Uh oh!

home-assistant Bot commented Feb 19, 2026

Uh oh!

Poshy163 commented Feb 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

joostlek left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Poshy163 commented Feb 19, 2026

Uh oh!

Poshy163 commented Feb 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

joostlek left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Poshy163 commented Feb 19, 2026 •

edited

Loading