fix: Do not forget segments from state when a new config arrives by Hypfer · Pull Request #170265 · home-assistant/core

Hypfer · 2026-05-10T13:34:59Z

Proposed change

When implementing the new area cleaning feature in Valetudo, I've noticed that Home Assistant needed to be restarted after Valetudo, as otherwise, the feature would not be available in the UI.

This was because any new config processed would reset the feature flags of the entity.

Probably an oversight because it's probably unusual for feature flags to change "at runtime".

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue:
This PR is related to issue:
Link to documentation pull request:
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2026-05-10T13:35:09Z

Hey there @emontnemery, @jbouwh, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant mark-draft Mark the pull request as draft.
@home-assistant ready-for-review Remove the draft status from the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign mqtt Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant update-branch Update the pull request branch with the base branch.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot

Pull request overview

Fixes MQTT vacuum clean-area capability being dropped on MQTT discovery/config updates by preserving the CLEAN_AREA feature when segments were already learned from state and the clean-segments command topic remains configured.

Changes:

Re-adds VacuumEntityFeature.CLEAN_AREA during _setup_from_config() when previously received segments exist and clean_segments_command_topic is configured.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Hypfer · 2026-05-10T15:12:14Z

I'm impressed that the LLM review also implements the very human "Give an inch and they take a mile".

@copilot
Do it yourself, clanker. You don't need me in the loop to prompt yet another LLM, nor is it my job to hug neurotic matrices of floats until they feel better about implausible hypotheticals.

(Yes, it can't read. I know.)

Hypfer · 2026-05-10T15:41:11Z

Not my test failing. Huh.

jbouwh · 2026-05-10T18:44:04Z

I'll have a look

jbouwh

Looks good. Left a few comments.

home-assistant · 2026-05-10T19:20:55Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

jbouwh

Looks good,
Thanks @Hypfer 👍

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

jbouwh · 2026-05-10T20:17:02Z

CI Test failure not related

Bump aiotankerkoenig to 0.5.3 (home-assistant#170224) Fix entities refresh for UptimeRobot (home-assistant#170217) Update easyEnergy exception and icon translations (home-assistant#170218) Add more Gen1 sensors to indevolt (home-assistant#170191) Bump letpot to 0.7.0 (home-assistant#169868) Migrate Thermo Beacon to config entry runtime data (home-assistant#170226) Migrate Sensirion BLE to config entry runtime data (home-assistant#170227) Co-authored-by: Josef Zweck <josef@zweck.dev> Bump imgw-pib to 2.1.2 (home-assistant#170274) Bump serialx to 1.7.2 (home-assistant#170272) Bump aioamazondevices to 13.5.0 (home-assistant#170258) Update upb-lib to 0.7.0 (home-assistant#170051) Bump qbittorrent-api to 2026.5.1 (home-assistant#170181) Use VERSION from PrusaLinkConfigFlow in prusalink (home-assistant#170200) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Migrate Duco to python-duco-connectivity and remove temperature sensors (home-assistant#170237) fix: Do not forget segments from state when a new config arrives (home-assistant#170265) Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Complete icon translations for Indevolt (home-assistant#170292) Align Indevolt quality scale with documentation (home-assistant#170289) Apply strict typing to Indevolt integration (home-assistant#170288) iaqualink: set system specific polling interval (home-assistant#170279) Use standby for HDMI-CEC turn off (home-assistant#170206) prusalink: add continue-job button for ATTENTION state (home-assistant#170193) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> data grand lyon: implement diagnostics (home-assistant#170184) Set serial port description from `description`, not `product` (home-assistant#170160) Co-authored-by: Paulus Schoutsen <balloob@gmail.com> Update infrared-protocols to 4.0.0 (home-assistant#170297) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> data grand lyon: use test fixture instead of manual patching (home-assistant#170294) Handle empty BSB-LAN heating circuits (home-assistant#170249) Add diagnostics platform to Home Assistant Connect ZBT-2 (home-assistant#170158) Fix deprecated_class to work with inheritance (home-assistant#170137) Skip offline devices instead of aborting ViCare diagnostics (home-assistant#170106) Fix local API incorrectly marking devices as unavailable in Overkiz (home-assistant#170118) Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io> Add RepairsFlowResult TypeAlias (home-assistant#170263) Fix flaky diagnostics test for Novy Cooker Hood (home-assistant#170299) Fix spelling of RS-232 in Denon RS-232 integration (home-assistant#170298) data grand lyon: implement reconfiguration flow (home-assistant#170210) Add shared test mocks for the Infrared integration (home-assistant#170296) Co-authored-by: Claude <noreply@anthropic.com> Bump renault-api to 0.5.8 (home-assistant#170309) Bump indevolt api to 1.7.2 (home-assistant#170310) Update IQS to platinum for UptimeRobot (home-assistant#170260) Add player specific sensor to nintendo_parental_controls (home-assistant#155786) Co-authored-by: Joshua Peisach (ItzSwirlz) <itzswirlz2020@outlook.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Erik Montnemery <erik@montnemery.com> Fix hassio.backup_partial AttributeError when folders are specified (home-assistant#170312) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Add backoff to forbidden packages (home-assistant#170242) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Add tuya water timer data points (home-assistant#170314) Add more entities for Tuya camera (home-assistant#169966) Co-authored-by: mik-laj <12058428+mik-laj@users.noreply.github.com> Co-authored-by: Norbert Rittel <norbert@rittel.de> Add Tuya DLQ fixture (home-assistant#169585) Update rf-protocols to 3.0.0 (home-assistant#170301) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Add Message Expire Interval option to MQTT publish service (home-assistant#169317) Co-authored-by: Copilot <copilot@github.com> Add new CentriConnect component (home-assistant#166933) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Watts: add HVAC action + preset mode (home-assistant#169546) Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Joostlek <joostlek@outlook.com> Add quality scale for airnow integration (home-assistant#169709) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Fix nobo_hub NoboProfileSelector class-level mutable defaults (home-assistant#170119) Add cover support to control4 (home-assistant#169417) Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> Add Mitsubishi brand (home-assistant#169924) Co-authored-by: Nikolai Rahimi <nikolairahimi@users.noreply.github.com> Co-authored-by: Paulus Schoutsen <balloob@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Fix coordinator data mutation in YouTube diagnostics (home-assistant#170300) Co-authored-by: FIls0010 <a1867444@adelaide.edu.au> Bump aiovodafone to 3.2.0 (home-assistant#170322) Add countdown number for Tuya sfkzq single-valve timers (home-assistant#170318) Allow setting hvac_mode in generic_thermostat.set_temperature (home-assistant#168062) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> Z-Wave.me: Allow updating entities (home-assistant#167839) Fix MQTT device discovery not using shared QoS and encoding options (home-assistant#170195) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Google assistant temperature setting active thermostat mode (home-assistant#166448) Co-authored-by: Lucas Sanchez Sagrado <lucas.sansag@educa.jcyl.es> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Add quality scale to Tesla Fleet integration (home-assistant#160475) Co-authored-by: Claude <noreply@anthropic.com> Only use SmartThings switch for light if it should (home-assistant#166424) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Add quality scale file to Ness Alarm (home-assistant#163425) Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> Fix Shelly media player availability (home-assistant#170319) Update discovery description wording (home-assistant#170325) Bump teltasync to 0.3.0, fix discovery for older devices (home-assistant#169660) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Complete exception translations for Indevolt (home-assistant#170291) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Add Kiosker switch platform (home-assistant#168858) Add `ZWaveNodeBaseEntity` for Z-Wave node-level entities (home-assistant#170124) Add number platform to eurotronic_cometblue (home-assistant#168119) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 10, 2026 13:35

Hypfer requested review from bdraco, emontnemery and jbouwh as code owners May 10, 2026 13:35

home-assistant Bot added bugfix cla-signed core integration: mqtt small-pr PRs with less than 30 lines. labels May 10, 2026

home-assistant Bot assigned emontnemery, jbouwh and bdraco May 10, 2026

home-assistant Bot added the Quality Scale: platinum label May 10, 2026

Copilot started reviewing on behalf of Hypfer May 10, 2026 13:35 View session

Copilot AI reviewed May 10, 2026

View reviewed changes

Comment thread homeassistant/components/mqtt/vacuum.py Outdated

fix: Do not forget segments from state when a new config arrives

6a56c86

Hypfer force-pushed the fix_mqtt_vacuum_area branch from 97f61ce to 6a56c86 Compare May 10, 2026 13:46

Copilot AI review requested due to automatic review settings May 10, 2026 15:02

Copilot started reviewing on behalf of Hypfer May 10, 2026 15:03 View session

Copilot AI reviewed May 10, 2026

View reviewed changes

Comment thread homeassistant/components/mqtt/vacuum.py Outdated

Comment thread tests/components/mqtt/test_vacuum.py

chore: Add test

8affdae

Hypfer force-pushed the fix_mqtt_vacuum_area branch from b2031b2 to 8affdae Compare May 10, 2026 15:16

jbouwh reviewed May 10, 2026

View reviewed changes

Comment thread homeassistant/components/mqtt/vacuum.py

Comment thread homeassistant/components/mqtt/vacuum.py Outdated

jbouwh requested changes May 10, 2026

View reviewed changes

home-assistant Bot marked this pull request as draft May 10, 2026 19:20

Update homeassistant/components/mqtt/vacuum.py

c4fb7f1

Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 10, 2026 19:28

Update homeassistant/components/mqtt/vacuum.py

7e5b726

Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com>

Copilot started reviewing on behalf of Hypfer May 10, 2026 19:29 View session

Merge branch 'dev' into fix_mqtt_vacuum_area

5e4f0d6

Copilot AI reviewed May 10, 2026

View reviewed changes

Comment thread homeassistant/components/mqtt/vacuum.py Outdated

Hypfer marked this pull request as ready for review May 10, 2026 19:37

home-assistant Bot requested a review from jbouwh May 10, 2026 19:37

Potential fix for pull request finding

ea57450

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 10, 2026 19:39

Copilot started reviewing on behalf of Hypfer May 10, 2026 19:40 View session

jbouwh approved these changes May 10, 2026

View reviewed changes

home-assistant Bot added the code-owner-approved label May 10, 2026

jbouwh added this to the 2026.5.2 milestone May 10, 2026

Copilot AI reviewed May 10, 2026

View reviewed changes

Comment thread tests/components/mqtt/test_vacuum.py

jbouwh merged commit cd945a4 into home-assistant:dev May 10, 2026
82 of 86 checks passed

github-actions Bot locked and limited conversation to collaborators May 11, 2026

frenck added the cherry-picked label May 15, 2026

Uh oh!

Conversation

Hypfer commented May 10, 2026 • edited by jbouwh Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant Bot commented May 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Hypfer commented May 10, 2026

Uh oh!

Hypfer commented May 10, 2026

Uh oh!

jbouwh commented May 10, 2026

Uh oh!

Uh oh!

Uh oh!

jbouwh left a comment

Choose a reason for hiding this comment

Uh oh!

home-assistant Bot commented May 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

jbouwh left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

jbouwh commented May 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Hypfer commented May 10, 2026 •

edited by jbouwh

Loading