Fix coordinator data mutation in YouTube diagnostics by TomFilsell · Pull Request #170300 · home-assistant/core

TomFilsell · 2026-05-11T02:54:55Z

Proposed change

async_get_config_entry_diagnostics was iterating directly over
coordinator.data, meaning channel_data was a reference into the
live coordinator data. Calling .pop(ATTR_DESCRIPTION) on it
permanently mutated the coordinator's state on every diagnostics fetch.

This fix wraps the iteration in dict(coordinator.data) so we iterate
over a shallow copy, leaving the coordinator's live data untouched.

Thanks to @jbouwh for the suggested approach.

Type of change

Bugfix (non-breaking change which fixes an issue)

Checklist

The code change is tested and works locally
Local tests pass
There is no commented out code in this PR
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff

home-assistant · 2026-05-11T02:55:03Z

Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration (youtube) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of youtube can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant mark-draft Mark the pull request as draft.
@home-assistant ready-for-review Remove the draft status from the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign youtube Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant update-branch Update the pull request branch with the base branch.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot

Pull request overview

Fixes diagnostics generation for the YouTube integration by avoiding unintended mutations of live DataUpdateCoordinator state when redacting fields from diagnostics output.

Changes:

Iterates over a copied mapping of coordinator.data while building the diagnostics payload.
Redacts description from latest_video in diagnostics output.

+    for channel_id, channel_data in dict(coordinator.data).items():
        channel_data.get(ATTR_LATEST_VIDEO, {}).pop(ATTR_DESCRIPTION)
        sensor_data[channel_id] = channel_data


    sensor_data: dict[str, Any] = {}
-    for channel_id, channel_data in coordinator.data.items():
+    for channel_id, channel_data in dict(coordinator.data).items():
        channel_data.get(ATTR_LATEST_VIDEO, {}).pop(ATTR_DESCRIPTION)


balloob · 2026-05-11T03:21:22Z

    coordinator = entry.runtime_data
    sensor_data: dict[str, Any] = {}
-    for channel_id, channel_data in coordinator.data.items():
+    for channel_id, channel_data in dict(coordinator.data).items():


This won't fix it, because it does a shallow copy. So channel_data[ATTR_LATEST_VIDEO] still points at a dictionary shared with real data.

You're right, thank you. Interestingly, this was my original approach in the previous PR (#170183) — deep copying channel_data and building a new latest_video dict excluding the description. However, @jbouwh suggested the simpler dict(coordinator.data) approach, which I implemented here.
I've now reverted to the deeper copy approach which correctly avoids mutating any live coordinator data:

for channel_id, channel_data in coordinator.data.items(): channel_copy = dict(channel_data) if latest_video := channel_copy.get(ATTR_LATEST_VIDEO): channel_copy[ATTR_LATEST_VIDEO] = { key: value for key, value in latest_video.items() if key != ATTR_DESCRIPTION } sensor_data[channel_id] = channel_copy

balloob

Does not solve issue.

home-assistant · 2026-05-11T03:21:37Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

    for channel_id, channel_data in coordinator.data.items():
-        channel_data.get(ATTR_LATEST_VIDEO, {}).pop(ATTR_DESCRIPTION)
-        sensor_data[channel_id] = channel_data
+        channel_copy = dict(channel_data)
+        if latest_video := channel_copy.get(ATTR_LATEST_VIDEO):
+            channel_copy[ATTR_LATEST_VIDEO] = {


+        channel_copy = dict(channel_data)
+        if latest_video := channel_copy.get(ATTR_LATEST_VIDEO):
+            channel_copy[ATTR_LATEST_VIDEO] = {
+                key: value
+                for key, value in latest_video.items()
+                if key != ATTR_DESCRIPTION
+            }
+        sensor_data[channel_id] = channel_copy


Bump aiotankerkoenig to 0.5.3 (home-assistant#170224) Fix entities refresh for UptimeRobot (home-assistant#170217) Update easyEnergy exception and icon translations (home-assistant#170218) Add more Gen1 sensors to indevolt (home-assistant#170191) Bump letpot to 0.7.0 (home-assistant#169868) Migrate Thermo Beacon to config entry runtime data (home-assistant#170226) Migrate Sensirion BLE to config entry runtime data (home-assistant#170227) Co-authored-by: Josef Zweck <josef@zweck.dev> Bump imgw-pib to 2.1.2 (home-assistant#170274) Bump serialx to 1.7.2 (home-assistant#170272) Bump aioamazondevices to 13.5.0 (home-assistant#170258) Update upb-lib to 0.7.0 (home-assistant#170051) Bump qbittorrent-api to 2026.5.1 (home-assistant#170181) Use VERSION from PrusaLinkConfigFlow in prusalink (home-assistant#170200) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Migrate Duco to python-duco-connectivity and remove temperature sensors (home-assistant#170237) fix: Do not forget segments from state when a new config arrives (home-assistant#170265) Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Complete icon translations for Indevolt (home-assistant#170292) Align Indevolt quality scale with documentation (home-assistant#170289) Apply strict typing to Indevolt integration (home-assistant#170288) iaqualink: set system specific polling interval (home-assistant#170279) Use standby for HDMI-CEC turn off (home-assistant#170206) prusalink: add continue-job button for ATTENTION state (home-assistant#170193) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> data grand lyon: implement diagnostics (home-assistant#170184) Set serial port description from `description`, not `product` (home-assistant#170160) Co-authored-by: Paulus Schoutsen <balloob@gmail.com> Update infrared-protocols to 4.0.0 (home-assistant#170297) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> data grand lyon: use test fixture instead of manual patching (home-assistant#170294) Handle empty BSB-LAN heating circuits (home-assistant#170249) Add diagnostics platform to Home Assistant Connect ZBT-2 (home-assistant#170158) Fix deprecated_class to work with inheritance (home-assistant#170137) Skip offline devices instead of aborting ViCare diagnostics (home-assistant#170106) Fix local API incorrectly marking devices as unavailable in Overkiz (home-assistant#170118) Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io> Add RepairsFlowResult TypeAlias (home-assistant#170263) Fix flaky diagnostics test for Novy Cooker Hood (home-assistant#170299) Fix spelling of RS-232 in Denon RS-232 integration (home-assistant#170298) data grand lyon: implement reconfiguration flow (home-assistant#170210) Add shared test mocks for the Infrared integration (home-assistant#170296) Co-authored-by: Claude <noreply@anthropic.com> Bump renault-api to 0.5.8 (home-assistant#170309) Bump indevolt api to 1.7.2 (home-assistant#170310) Update IQS to platinum for UptimeRobot (home-assistant#170260) Add player specific sensor to nintendo_parental_controls (home-assistant#155786) Co-authored-by: Joshua Peisach (ItzSwirlz) <itzswirlz2020@outlook.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Erik Montnemery <erik@montnemery.com> Fix hassio.backup_partial AttributeError when folders are specified (home-assistant#170312) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Add backoff to forbidden packages (home-assistant#170242) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Add tuya water timer data points (home-assistant#170314) Add more entities for Tuya camera (home-assistant#169966) Co-authored-by: mik-laj <12058428+mik-laj@users.noreply.github.com> Co-authored-by: Norbert Rittel <norbert@rittel.de> Add Tuya DLQ fixture (home-assistant#169585) Update rf-protocols to 3.0.0 (home-assistant#170301) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Add Message Expire Interval option to MQTT publish service (home-assistant#169317) Co-authored-by: Copilot <copilot@github.com> Add new CentriConnect component (home-assistant#166933) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Watts: add HVAC action + preset mode (home-assistant#169546) Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Joostlek <joostlek@outlook.com> Add quality scale for airnow integration (home-assistant#169709) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Fix nobo_hub NoboProfileSelector class-level mutable defaults (home-assistant#170119) Add cover support to control4 (home-assistant#169417) Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> Add Mitsubishi brand (home-assistant#169924) Co-authored-by: Nikolai Rahimi <nikolairahimi@users.noreply.github.com> Co-authored-by: Paulus Schoutsen <balloob@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Fix coordinator data mutation in YouTube diagnostics (home-assistant#170300) Co-authored-by: FIls0010 <a1867444@adelaide.edu.au> Bump aiovodafone to 3.2.0 (home-assistant#170322) Add countdown number for Tuya sfkzq single-valve timers (home-assistant#170318) Allow setting hvac_mode in generic_thermostat.set_temperature (home-assistant#168062) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> Z-Wave.me: Allow updating entities (home-assistant#167839) Fix MQTT device discovery not using shared QoS and encoding options (home-assistant#170195) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Google assistant temperature setting active thermostat mode (home-assistant#166448) Co-authored-by: Lucas Sanchez Sagrado <lucas.sansag@educa.jcyl.es> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Add quality scale to Tesla Fleet integration (home-assistant#160475) Co-authored-by: Claude <noreply@anthropic.com> Only use SmartThings switch for light if it should (home-assistant#166424) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Add quality scale file to Ness Alarm (home-assistant#163425) Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> Fix Shelly media player availability (home-assistant#170319) Update discovery description wording (home-assistant#170325) Bump teltasync to 0.3.0, fix discovery for older devices (home-assistant#169660) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Complete exception translations for Indevolt (home-assistant#170291) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Add Kiosker switch platform (home-assistant#168858) Add `ZWaveNodeBaseEntity` for Z-Wave node-level entities (home-assistant#170124) Add number platform to eurotronic_cometblue (home-assistant#168119) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…170300) Co-authored-by: FIls0010 <a1867444@adelaide.edu.au>

Fix coordinator data mutation in YouTube diagnostics

3e95070

Copilot AI review requested due to automatic review settings May 11, 2026 02:54

TomFilsell requested a review from joostlek as a code owner May 11, 2026 02:54

home-assistant Bot added bugfix cla-signed integration: youtube small-pr PRs with less than 30 lines. labels May 11, 2026

home-assistant Bot assigned joostlek May 11, 2026

home-assistant Bot added the Quality Scale: No score label May 11, 2026

Copilot started reviewing on behalf of TomFilsell May 11, 2026 02:55 View session

TomFilsell mentioned this pull request May 11, 2026

Fix coordinator data mutation in YouTube diagnostics #170183

Closed

12 tasks

Copilot AI reviewed May 11, 2026

View reviewed changes

balloob reviewed May 11, 2026

View reviewed changes

balloob requested changes May 11, 2026

View reviewed changes

home-assistant Bot marked this pull request as draft May 11, 2026 03:21

Fix coordinator data mutation in YouTube diagnostics

8d3e32e

TomFilsell requested a review from balloob May 11, 2026 03:39

balloob approved these changes May 11, 2026

View reviewed changes

balloob marked this pull request as ready for review May 11, 2026 12:03

Copilot AI review requested due to automatic review settings May 11, 2026 12:03

home-assistant Bot requested a review from balloob May 11, 2026 12:03

balloob merged commit 095de73 into home-assistant:dev May 11, 2026
29 checks passed

Copilot started reviewing on behalf of balloob May 11, 2026 12:04 View session

Copilot AI reviewed May 11, 2026

View reviewed changes

lmaertin pushed a commit to lmaertin/homeassistant-core that referenced this pull request May 11, 2026

Fix coordinator data mutation in YouTube diagnostics (home-assistant#…

374be5e

…170300) Co-authored-by: FIls0010 <a1867444@adelaide.edu.au>

github-actions Bot locked and limited conversation to collaborators May 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix coordinator data mutation in YouTube diagnostics#170300

Fix coordinator data mutation in YouTube diagnostics#170300
balloob merged 2 commits into
home-assistant:devfrom
TomFilsell:fix/youtube-diagnostics-v2

TomFilsell commented May 11, 2026

Uh oh!

home-assistant Bot commented May 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

balloob May 11, 2026

Uh oh!

TomFilsell May 11, 2026 •

edited

Loading

Uh oh!

balloob left a comment

Uh oh!

home-assistant Bot commented May 11, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

TomFilsell commented May 11, 2026

Proposed change

Type of change

Checklist

Uh oh!

home-assistant Bot commented May 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

balloob May 11, 2026

Choose a reason for hiding this comment

Uh oh!

TomFilsell May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

balloob left a comment

Choose a reason for hiding this comment

Uh oh!

home-assistant Bot commented May 11, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TomFilsell May 11, 2026 •

edited

Loading