Add cover support to control4 by nayfield · Pull Request #169417 · home-assistant/core

nayfield · 2026-04-29T01:40:47Z

Proposed change

Initial implementation of 'cover' support for control4

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

I have submitted a doc PR at home-assistant/home-assistant.io#45066

home-assistant

Hi @nayfield

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant · 2026-04-29T01:40:54Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

home-assistant · 2026-04-29T01:40:57Z

Hey there @lawtancool, @davidrecordon, mind taking a look at this pull request as it has been labeled with an integration (control4) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of control4 can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant mark-draft Mark the pull request as draft.
@home-assistant ready-for-review Remove the draft status from the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign control4 Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant update-branch Update the pull request branch with the base branch.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot

Pull request overview

Adds initial Cover platform support to the existing control4 integration, enabling Control4 blinds/shades to appear as Home Assistant cover entities and be controlled via standard cover services.

Changes:

Introduces a new cover platform (Control4Cover) backed by a DataUpdateCoordinator that polls Control4 blind/shade variables.
Extends the integration’s forwarded platforms to include Platform.COVER.
Adds Control4 cover test coverage and updates the director items fixture with a representative blind/shade item.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
`homeassistant/components/control4/__init__.py`	Adds `Platform.COVER` to forwarded platforms so the new cover platform is loaded.
`homeassistant/components/control4/cover.py`	Implements Control4 cover entity setup, polling, and service methods (open/close/stop/set position).
`tests/components/control4/test_cover.py`	Adds tests for entity creation, state mapping, and service calls.
`tests/components/control4/fixtures/director_all_items.json`	Extends the fixture data with a blinds/shades item and its parent device.

Copilot · 2026-04-29T01:44:50Z

+from . import Control4ConfigEntry, Control4RuntimeData, get_items_of_category
+from .const import CONTROL4_ENTITY_TYPE
+from .director_utils import update_variables_for_config_entry
+from .entity import Control4Entity
+


Remove the unused Control4RuntimeData import (or use it in type hints) to avoid failing Ruff's unused-import checks.

Copilot · 2026-04-29T01:44:50Z

+    await coordinator.async_refresh()
+
+    items_of_category = await get_items_of_category(hass, entry, CONTROL4_CATEGORY)
+    entity_list = []
+    for item in items_of_category:
+        try:
+            if item["type"] != CONTROL4_ENTITY_TYPE:
+                continue
+            item_name = item["name"]
+            item_id = item["id"]
+            item_parent_id = item["parentId"]
+            item_manufacturer = None
+            item_device_name = None
+            item_model = None
+
+            for parent_item in items_of_category:
+                if parent_item["id"] == item_parent_id:
+                    item_manufacturer = parent_item.get("manufacturer")
+                    item_device_name = parent_item.get("roomName")
+                    item_model = parent_item.get("model")
+        except KeyError:
+            _LOGGER.exception(
+                "Unknown device properties received from Control4: %s",
+                item,
+            )
+            continue
+
+        if item_id not in coordinator.data:
+            _LOGGER.warning(
+                "Couldn't get cover state data for %s (ID: %s), skipping setup",
+                item_name,
+                item_id,
+            )
+            continue


Use coordinator.async_config_entry_first_refresh() (or otherwise guard coordinator.data being None) so setup doesn't crash when the initial refresh fails.

Copilot · 2026-04-29T01:44:51Z

+    """Control4 cover entity."""
+
+    _attr_has_entity_name = True
+    _attr_translation_key = "blind"


Either add the cover.blind translation key to strings.json/icons.json or drop _attr_translation_key to avoid missing-translation warnings at runtime.

Suggested change

_attr_translation_key = "blind"

Copilot · 2026-04-29T01:44:51Z

+    """Test cover entities are set up correctly with proper attributes."""
+    await snapshot_platform(hass, entity_registry, snapshot, mock_config_entry.entry_id)


Add the Syrupy snapshot file for test_cover_entities (or switch this test to explicit assertions) so CI doesn't fail due to missing snapshots.

Stale

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

+    """Test cover entities are set up correctly with proper attributes."""
+    await snapshot_platform(hass, entity_registry, snapshot, mock_config_entry.entry_id)
+


+        config_entry=entry,
+    )
+
+    await coordinator.async_refresh()


+    items_of_category = await get_items_of_category(hass, entry, CONTROL4_CATEGORY)
+    entity_list = []
+    for item in items_of_category:
+        try:
+            if item["type"] != CONTROL4_ENTITY_TYPE:
+                continue
+            item_name = item["name"]
+            item_id = item["id"]
+            item_parent_id = item["parentId"]
+            item_manufacturer = None
+            item_device_name = None
+            item_model = None
+
+            for parent_item in items_of_category:
+                if parent_item["id"] == item_parent_id:
+                    item_manufacturer = parent_item.get("manufacturer")
+                    item_device_name = parent_item.get("roomName")
+                    item_model = parent_item.get("model")


+    """Control4 cover entity."""
+
+    _attr_has_entity_name = True
+    _attr_translation_key = "blind"


Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

nayfield · 2026-05-02T00:59:30Z

docs PR is home-assistant/home-assistant.io#45066

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

+@pytest.mark.parametrize(
+    ("mock_cover_variables", "expected_state", "expected_position"),
+    [
+        pytest.param(
+            _make_cover_data(level=0, fully_closed=True),
+            CoverState.CLOSED,
+            0,
+            id="closed",
+        ),
+        pytest.param(
+            _make_cover_data(level=100, fully_open=True),
+            CoverState.OPEN,
+            100,
+            id="open",
+        ),
+        pytest.param(
+            _make_cover_data(level=42),
+            CoverState.OPEN,
+            42,
+            id="partial",
+        ),
+        pytest.param(
+            _make_cover_data(level=70, opening=True),
+            CoverState.OPENING,
+            70,
+            id="opening",
+        ),
+        pytest.param(
+            _make_cover_data(level=30, closing=True),
+            CoverState.CLOSING,
+            30,
+            id="closing",
+        ),
+    ],
+)


+async def test_cover_states(
+    hass: HomeAssistant,
+    expected_state: str,
+    expected_position: int,
+) -> None:


+        config_entry=entry,
+    )
+
+    await coordinator.async_refresh()


+        if item_id not in coordinator.data:
+            _LOGGER.warning(
+                "Couldn't get cover state data for %s (ID: %s), skipping setup",
+                item_name,
+                item_id,
+            )
+            continue


+    def _cover_data(self) -> dict[str, Any] | None:
+        """Return the cover data from the coordinator."""
+        return self.coordinator.data.get(self._idx)


+    items_of_category = await get_items_of_category(hass, entry, CONTROL4_CATEGORY)
+    entity_list = []
+    for item in items_of_category:
+        try:
+            if item["type"] != CONTROL4_ENTITY_TYPE:
+                continue
+            item_name = item["name"]
+            item_id = item["id"]
+            item_parent_id = item["parentId"]
+            item_manufacturer = None
+            item_device_name = None
+            item_model = None
+
+            for parent_item in items_of_category:
+                if parent_item["id"] == item_parent_id:
+                    item_manufacturer = parent_item.get("manufacturer")
+                    item_device_name = parent_item.get("roomName")
+                    item_model = parent_item.get("model")


+    items_of_category = await get_items_of_category(hass, entry, CONTROL4_CATEGORY)
+    entity_list = []
+    for item in items_of_category:


+            for parent_item in items_of_category:
+                if parent_item["id"] == item_parent_id:
+                    item_manufacturer = parent_item.get("manufacturer")
+                    item_device_name = parent_item.get("roomName")
+                    item_model = parent_item.get("model")


nayfield · 2026-05-02T02:21:31Z

I felt really good when I was able to take my changed code into custom components, restart HA, and control my blinds from my home-assistant.

But MAN the experience has been shit since then.

I get a ton of AI slop telling me to fix things
I fix some things, but still getting failures
The failures aren't obvious
press the button and some AI slop comes and tells me there's no way to tell what the error means unless I build venvs and run the tests myself
since i already have a venv for the project, i put ruff in it and it gives me a very clear unused import problem which your AI didn't expose, nor did the github AI that ran when I clicked on explain this problem
fine I fix that
now I'm failing NEW tests (that weren't failing previously).
I give up. Since you've destroyed several acres of rainforest to complain, I go ballistic and install some AI slop to fight with your AI slop
My AI figures out what your AI is upset about, and fixes it
I still have to suss out how the docs-missing works (you need to link to a docs PR from the code PR - the opposite does not work)
I finally get the code PR to pass all checks
But the Docs PR is failing. I made that PR in the github web UI (since it's just a oneliner change to docs) .. but somehow the web UI defaults to merge instead of rebase. I clicked on a button instead of the drop-down arrow to see my choices.
Fuck it, I need to check out the Docs repo on a real machine to do some git surgery to undo this stupid webUI default.
git clone hangs / github is down ATM - because it's overloaded due to all this AI slop activity

I'm giving up now.

Please understand - I am fully capable of doing an interactive git rebase to fix the state the web-ui put my PR into ... But I literally can't right now, - because too many AI slop agents took github down.

I totally understand the challenge of big upstream projects getting inundated by slop PRs that were generated with AI.

But please consider - if you employ more AI to defend against AI slop ... you're putting a barrier up that will keep competent developers - those who write code for a living - to decide to say "It's not worth the time to try and commit to the AI slop machine".

joostlek · 2026-05-04T21:36:57Z

+
+    state = hass.states.get(ENTITY_ID)
+    assert state is not None
+    assert state.state == STATE_UNAVAILABLE


We shouldn't touch entity component. Instead we should have the mock return what we expect and have the coordinator trigger a "natural" refresh (either by freezing and skipping time)

joostlek · 2026-05-04T21:41:29Z

When looking at this PR it looked quite good though! We're still looking how we can use AI correctly, also because we have like 250 more open PRs than we used to have and that's why we try to make sure the code is at a good point when the first human reviewer comes by. I think a lot of things are still taken with a bit of salt and I'd still recommend to trust your gut.

In any case, I think this could be ready to be merged, happy to help out :)

nayfield · 2026-05-04T22:39:00Z

Thanks, I'll take a look next weekend.

this is an attempt to avoid pushing data into the component, instead, clear the mocked variables and advance the freezer, so it gets the empty data naturally.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

+    await coordinator.async_refresh()
+


+    """Control4 cover entity."""
+
+    _attr_has_entity_name = True
+    _attr_translation_key = "blind"


Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

+    """Control4 cover entity."""
+
+    _attr_has_entity_name = True
+    _attr_translation_key = "blind"


+            for parent_item in items_of_category:
+                if parent_item["id"] == item_parent_id:
+                    item_manufacturer = parent_item.get("manufacturer")
+                    item_device_name = parent_item.get("roomName")
+                    item_model = parent_item.get("model")


+    coordinator = DataUpdateCoordinator[dict[int, dict[str, Any]]](
+        hass,
+        _LOGGER,
+        name="cover",
+        update_method=async_update_data,
+        update_interval=timedelta(seconds=runtime_data.scan_interval),
+        config_entry=entry,
+    )
+
+    await coordinator.async_refresh()
+


+        if data is None:
+            return None
+        if (fully_closed := data.get(CONTROL4_FULLY_CLOSED)) is not None:
+            return bool(fully_closed)


+            80,
+            CoverState.OPEN,
+            id="level_only_open",
+        ),


nayfield · 2026-05-09T01:38:44Z

Thanks for the feedback, I think I've got something that will work.

Is there a comprehensive 'HOWTO set up your dev environment' for HA?

Unfortunately the AI removed the previous comments in this PR, but at the very end before it was all passing, prek was failing. I could tell it was ruff from the prek logs, but I just eyeballed that I had a newline and removed it.

This was a candidate for automatic reformatting ruff, and I'm quite used to pre-commit rejecting but reformatting these sort of errors so i just repeat the last commit with the fixed file. It would be a lot less friction of HA were to use a precommit hook that would do this on commit. I've probably not set things up correctly on my end.

Anyway - if you're happy with how I avoided pushing data into the component, I think this is ready to merge.

joostlek

In our dev docs is a guide on how to do that

Bump aiotankerkoenig to 0.5.3 (home-assistant#170224) Fix entities refresh for UptimeRobot (home-assistant#170217) Update easyEnergy exception and icon translations (home-assistant#170218) Add more Gen1 sensors to indevolt (home-assistant#170191) Bump letpot to 0.7.0 (home-assistant#169868) Migrate Thermo Beacon to config entry runtime data (home-assistant#170226) Migrate Sensirion BLE to config entry runtime data (home-assistant#170227) Co-authored-by: Josef Zweck <josef@zweck.dev> Bump imgw-pib to 2.1.2 (home-assistant#170274) Bump serialx to 1.7.2 (home-assistant#170272) Bump aioamazondevices to 13.5.0 (home-assistant#170258) Update upb-lib to 0.7.0 (home-assistant#170051) Bump qbittorrent-api to 2026.5.1 (home-assistant#170181) Use VERSION from PrusaLinkConfigFlow in prusalink (home-assistant#170200) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Migrate Duco to python-duco-connectivity and remove temperature sensors (home-assistant#170237) fix: Do not forget segments from state when a new config arrives (home-assistant#170265) Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Complete icon translations for Indevolt (home-assistant#170292) Align Indevolt quality scale with documentation (home-assistant#170289) Apply strict typing to Indevolt integration (home-assistant#170288) iaqualink: set system specific polling interval (home-assistant#170279) Use standby for HDMI-CEC turn off (home-assistant#170206) prusalink: add continue-job button for ATTENTION state (home-assistant#170193) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> data grand lyon: implement diagnostics (home-assistant#170184) Set serial port description from `description`, not `product` (home-assistant#170160) Co-authored-by: Paulus Schoutsen <balloob@gmail.com> Update infrared-protocols to 4.0.0 (home-assistant#170297) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> data grand lyon: use test fixture instead of manual patching (home-assistant#170294) Handle empty BSB-LAN heating circuits (home-assistant#170249) Add diagnostics platform to Home Assistant Connect ZBT-2 (home-assistant#170158) Fix deprecated_class to work with inheritance (home-assistant#170137) Skip offline devices instead of aborting ViCare diagnostics (home-assistant#170106) Fix local API incorrectly marking devices as unavailable in Overkiz (home-assistant#170118) Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io> Add RepairsFlowResult TypeAlias (home-assistant#170263) Fix flaky diagnostics test for Novy Cooker Hood (home-assistant#170299) Fix spelling of RS-232 in Denon RS-232 integration (home-assistant#170298) data grand lyon: implement reconfiguration flow (home-assistant#170210) Add shared test mocks for the Infrared integration (home-assistant#170296) Co-authored-by: Claude <noreply@anthropic.com> Bump renault-api to 0.5.8 (home-assistant#170309) Bump indevolt api to 1.7.2 (home-assistant#170310) Update IQS to platinum for UptimeRobot (home-assistant#170260) Add player specific sensor to nintendo_parental_controls (home-assistant#155786) Co-authored-by: Joshua Peisach (ItzSwirlz) <itzswirlz2020@outlook.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Erik Montnemery <erik@montnemery.com> Fix hassio.backup_partial AttributeError when folders are specified (home-assistant#170312) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Add backoff to forbidden packages (home-assistant#170242) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Add tuya water timer data points (home-assistant#170314) Add more entities for Tuya camera (home-assistant#169966) Co-authored-by: mik-laj <12058428+mik-laj@users.noreply.github.com> Co-authored-by: Norbert Rittel <norbert@rittel.de> Add Tuya DLQ fixture (home-assistant#169585) Update rf-protocols to 3.0.0 (home-assistant#170301) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Add Message Expire Interval option to MQTT publish service (home-assistant#169317) Co-authored-by: Copilot <copilot@github.com> Add new CentriConnect component (home-assistant#166933) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Watts: add HVAC action + preset mode (home-assistant#169546) Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Joostlek <joostlek@outlook.com> Add quality scale for airnow integration (home-assistant#169709) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Fix nobo_hub NoboProfileSelector class-level mutable defaults (home-assistant#170119) Add cover support to control4 (home-assistant#169417) Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> Add Mitsubishi brand (home-assistant#169924) Co-authored-by: Nikolai Rahimi <nikolairahimi@users.noreply.github.com> Co-authored-by: Paulus Schoutsen <balloob@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Fix coordinator data mutation in YouTube diagnostics (home-assistant#170300) Co-authored-by: FIls0010 <a1867444@adelaide.edu.au> Bump aiovodafone to 3.2.0 (home-assistant#170322) Add countdown number for Tuya sfkzq single-valve timers (home-assistant#170318) Allow setting hvac_mode in generic_thermostat.set_temperature (home-assistant#168062) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> Z-Wave.me: Allow updating entities (home-assistant#167839) Fix MQTT device discovery not using shared QoS and encoding options (home-assistant#170195) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Google assistant temperature setting active thermostat mode (home-assistant#166448) Co-authored-by: Lucas Sanchez Sagrado <lucas.sansag@educa.jcyl.es> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Add quality scale to Tesla Fleet integration (home-assistant#160475) Co-authored-by: Claude <noreply@anthropic.com> Only use SmartThings switch for light if it should (home-assistant#166424) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Add quality scale file to Ness Alarm (home-assistant#163425) Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> Fix Shelly media player availability (home-assistant#170319) Update discovery description wording (home-assistant#170325) Bump teltasync to 0.3.0, fix discovery for older devices (home-assistant#169660) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Complete exception translations for Indevolt (home-assistant#170291) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Add Kiosker switch platform (home-assistant#168858) Add `ZWaveNodeBaseEntity` for Z-Wave node-level entities (home-assistant#170124) Add number platform to eurotronic_cometblue (home-assistant#168119) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

Initial commit of cover support for control4

0fb39b0

Copilot AI review requested due to automatic review settings April 29, 2026 01:40

home-assistant Bot previously requested changes Apr 29, 2026

View reviewed changes

home-assistant Bot added cla-needed has-tests integration: control4 new-feature new-platform labels Apr 29, 2026

home-assistant Bot marked this pull request as draft April 29, 2026 01:40

home-assistant Bot added the Quality Scale: No score label Apr 29, 2026

Copilot started reviewing on behalf of nayfield April 29, 2026 01:41 View session

home-assistant Bot added cla-recheck cla-signed and removed cla-recheck cla-needed labels Apr 29, 2026

Copilot AI reviewed Apr 29, 2026

View reviewed changes

nayfield force-pushed the c4_cover branch from 122680b to 0fb39b0 Compare April 29, 2026 02:06

Merge branch 'dev' into c4_cover

52adad6

Copilot AI review requested due to automatic review settings May 2, 2026 00:31

Copilot started reviewing on behalf of nayfield May 2, 2026 00:32 View session

nayfield marked this pull request as ready for review May 2, 2026 00:33

Copilot AI reviewed May 2, 2026

View reviewed changes

nayfield and others added 2 commits May 1, 2026 19:44

ruff

4179faa

Add snapshot for control4 cover entity test

127eb78

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings May 2, 2026 00:58

Copilot started reviewing on behalf of nayfield May 2, 2026 00:59 View session

Copilot started reviewing on behalf of nayfield May 2, 2026 01:18 View session

Copilot AI reviewed May 2, 2026

View reviewed changes

joostlek requested changes May 4, 2026

View reviewed changes

home-assistant Bot marked this pull request as draft May 4, 2026 21:37

nayfield added 2 commits May 8, 2026 19:53

update for the control4 cover test.

0e441f5

this is an attempt to avoid pushing data into the component, instead, clear the mocked variables and advance the freezer, so it gets the empty data naturally.

remove future as HA requires 3.14+

c28e1d9

Copilot AI review requested due to automatic review settings May 9, 2026 01:00

Copilot started reviewing on behalf of nayfield May 9, 2026 01:01 View session

Copilot AI reviewed May 9, 2026

View reviewed changes

Comment thread homeassistant/components/control4/cover.py

Comment on lines +71 to +72

await coordinator.async_refresh()

Comment thread homeassistant/components/control4/cover.py

"""Control4 cover entity."""

_attr_has_entity_name = True

_attr_translation_key = "blind"

guessing this is why your ruff is failing while mine is fine

54be632

nayfield marked this pull request as ready for review May 9, 2026 01:12

Copilot AI review requested due to automatic review settings May 9, 2026 01:12

home-assistant Bot requested a review from joostlek May 9, 2026 01:12

Copilot started reviewing on behalf of nayfield May 9, 2026 01:13 View session

Copilot AI reviewed May 9, 2026

View reviewed changes

joostlek changed the title ~~control4 add cover support~~ dd cover support May 11, 2026

joostlek changed the title ~~dd cover support~~ Add cover support to control4 May 11, 2026

joostlek approved these changes May 11, 2026

View reviewed changes

joostlek merged commit 0a974cb into home-assistant:dev May 11, 2026
36 of 37 checks passed

lmaertin pushed a commit to lmaertin/homeassistant-core that referenced this pull request May 11, 2026

Add cover support to control4 (home-assistant#169417)

94c1fa3

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

github-actions Bot locked and limited conversation to collaborators May 12, 2026

		"""Test cover entities are set up correctly with proper attributes."""
		await snapshot_platform(hass, entity_registry, snapshot, mock_config_entry.entry_id)

Uh oh!

Conversation

nayfield commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant Bot left a comment

Choose a reason for hiding this comment

Uh oh!

home-assistant Bot commented Apr 29, 2026

Uh oh!

home-assistant Bot commented Apr 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

nayfield commented May 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

nayfield commented May 2, 2026

Uh oh!

joostlek May 4, 2026

Choose a reason for hiding this comment

Uh oh!

joostlek commented May 4, 2026

Uh oh!

nayfield commented May 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

nayfield commented May 9, 2026

Uh oh!

joostlek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nayfield commented Apr 29, 2026 •

edited

Loading