Add quality scale file to Ness Alarm #163425
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,80 @@ | ||||||
| rules: | ||||||
|
Member
There was a problem hiding this comment. Why do we actually iterate twice over all the subentries in binary sensor setup?
Member
There was a problem hiding this comment. Currently the binary sensor is always initalized with False, should that be |
||||||
| # Bronze | ||||||
| action-setup: done | ||||||
|
Member
There was a problem hiding this comment. Sidenote, I am wondering what the best way is to make these services nice, as they currently pick the first entry. Would it make sense to either
(not a blocker for this, but I think just picking the first one is bad) |
||||||
| appropriate-polling: done | ||||||
| brands: done | ||||||
| common-modules: done | ||||||
| config-flow: done | ||||||
| config-flow-test-coverage: done | ||||||
| dependency-transparency: done | ||||||
| docs-actions: done | ||||||
| docs-high-level-description: done | ||||||
| docs-installation-instructions: done | ||||||
| docs-removal-instructions: done | ||||||
| entity-event-setup: done | ||||||
| entity-unique-id: done | ||||||
| has-entity-name: done | ||||||
|
Poshy163 marked this conversation as resolved.
Member
There was a problem hiding this comment.
Suggested change
|
||||||
| runtime-data: done | ||||||
| test-before-configure: done | ||||||
| test-before-setup: done | ||||||
| unique-config-entry: done | ||||||
|
|
||||||
| # Silver | ||||||
| action-exceptions: | ||||||
| status: todo | ||||||
| comment: | | ||||||
| Alarm actions (arm/disarm/trigger) currently call client methods directly | ||||||
| without integration-level exception handling. | ||||||
| config-entry-unloading: done | ||||||
| docs-configuration-parameters: todo | ||||||
| docs-installation-parameters: todo | ||||||
| entity-unavailable: | ||||||
| status: todo | ||||||
| comment: Binary sensor initial state should be None (unknown) instead of False. | ||||||
| integration-owner: done | ||||||
| log-when-unavailable: todo | ||||||
| parallel-updates: todo | ||||||
| reauthentication-flow: todo | ||||||
| test-coverage: | ||||||
| status: todo | ||||||
| comment: | | ||||||
| Switch from MockClient to proper AsyncMock. | ||||||
| More tests in test_init.py should use mock_config_entry fixture. | ||||||
|
|
||||||
| # Gold | ||||||
| devices: | ||||||
| status: done | ||||||
| comment: | | ||||||
| Binary sensors linked to main device via via_device. | ||||||
| Consider improving services to not just pick the first config entry. | ||||||
| diagnostics: todo | ||||||
| discovery-update-info: todo | ||||||
| discovery: todo | ||||||
| docs-data-update: todo | ||||||
| docs-examples: todo | ||||||
| docs-known-limitations: todo | ||||||
| docs-supported-devices: todo | ||||||
| docs-supported-functions: todo | ||||||
| docs-troubleshooting: todo | ||||||
| docs-use-cases: todo | ||||||
| dynamic-devices: todo | ||||||
| entity-category: | ||||||
| status: exempt | ||||||
| comment: No entities need a non-default category. | ||||||
| entity-device-class: done | ||||||
| entity-disabled-by-default: todo | ||||||
| entity-translations: | ||||||
| status: exempt | ||||||
| comment: Entities use device name as entity name. | ||||||
| exception-translations: done | ||||||
| icon-translations: | ||||||
| status: exempt | ||||||
| comment: No entity icons are used. | ||||||
| reconfiguration-flow: todo | ||||||
| repair-issues: done | ||||||
| stale-devices: todo | ||||||
|
|
||||||
| # Platinum | ||||||
| async-dependency: todo | ||||||
| inject-websession: todo | ||||||
| strict-typing: todo | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -655,7 +655,6 @@ class Rule: | |
| "nasweb", | ||
| "neato", | ||
| "nederlandse_spoorwegen", | ||
| "netatmo", | ||
| "netdata", | ||
| "netgear", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
async_at_startedshould be wrapped inentry.async_on_unload