Fix hassio.backup_partial AttributeError when folders are specified by agners · Pull Request #170312 · home-assistant/core

agners · 2026-05-11T08:18:00Z

Breaking change

Proposed change

After #166558 switched hassio.backup_partial / hassio.restore_partial to aiohasupervisor, the service schema still produced a set[str] for folders, but PartialBackupOptions.folders is typed set[Folder]. mashumaro's to_dict() then fails with:

AttributeError: 'str' object has no attribute 'value'

Additionally, the legacy "homeassistant" folder value (still accepted by Supervisor via v1_folderlist) is no longer part of the Folder enum, so any existing automation passing it would silently break.

This change:

Validates folder names against the Folder enum at schema time and converts them before constructing the options.
Translates the legacy "homeassistant" folder value to homeassistant=True to preserve backwards compatibility with existing automations.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes hassio.backup_partial fails with AttributeError: 'str' object has no attribute 'value' when folders are specified #170175
This PR is related to issue:
Link to documentation pull request:
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

The aiohasupervisor PartialBackupOptions.folders expects set[Folder], but the service schema produced a set[str]. mashumaro's to_dict() then failed with AttributeError: 'str' object has no attribute 'value'. Validate folder names against the Folder enum and convert them before constructing the options. Translate the legacy "homeassistant" folder value to homeassistant=True for backwards compatibility with existing automations. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

home-assistant · 2026-05-11T08:18:10Z

Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration (hassio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hassio can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant mark-draft Mark the pull request as draft.
@home-assistant ready-for-review Remove the draft status from the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign hassio Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant update-branch Update the pull request branch with the base branch.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

agners · 2026-05-11T08:20:56Z

Translates the legacy "homeassistant" folder value to homeassistant=True to preserve backwards compatibility with existing automations.

I wonder should (can?) we maybe deprecate homeassistant string in the folder list? How can we deprecate this (log a warning, raise a repair, something else?)

Copilot

Pull request overview

Fixes Supervisor partial backup/restore service handling after the aiohasupervisor migration by validating and converting folders to the expected Folder enum type, and preserving backwards compatibility for the legacy "homeassistant" folder value.

Changes:

Add schema-time validation for folders against aiohasupervisor.models.Folder and convert folder strings to Folder enums before building backup/restore options.
Translate legacy "homeassistant" folder usage into homeassistant=True to avoid breaking existing automations.
Update and extend hassio tests to assert Folder enum usage and cover the legacy mapping + invalid folder names.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
`homeassistant/components/hassio/services.py`	Validates folder names and normalizes service data to `Folder` enums; adds legacy `"homeassistant"` mapping.
`tests/components/hassio/test_init.py`	Updates assertions for `Folder` enums and adds new tests for legacy folder translation and invalid folder rejection.

The helper is used by both partial backup and partial restore handlers, so the previous name was misleading. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

If a caller explicitly passes homeassistant=False alongside the legacy "homeassistant" entry in folders, silently flipping homeassistant to True would back up/restore the HA config against the caller's intent. Raise ServiceValidationError on this conflict instead. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

The same normalization runs for both partial backup and partial restore, so verify the backwards-compatibility mapping is exercised for restore as well. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

home-assistant · 2026-05-11T08:35:38Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

MartinHjelmare · 2026-05-11T08:38:58Z

Translates the legacy "homeassistant" folder value to homeassistant=True to preserve backwards compatibility with existing automations.

I wonder should (can?) we maybe deprecate homeassistant string in the folder list? How can we deprecate this (log a warning, raise a repair, something else?)

Yes, create a repair issue for deprecations in service actions. It should have is_fixable=True and is_persistent=True which will use the default repair flow. The user can confirm it's fixed after the automations or scripts are updated.

Drop the custom _valid_folder validator in favor of vol.Any(LEGACY_FOLDER_HOMEASSISTANT, vol.Coerce(Folder)) in the schema. The schema now produces the Folder enum directly, so the conversion in _normalize_partial_options_data is no longer needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

agners · 2026-05-11T08:43:27Z

Yes, create a repair issue for deprecations in service actions.

Hm, I'd like to have this part of 2026.5.2 since it fixes a bug. However, introducing a new deprecation repair is maybe not ideal of a patch release? 🤔 Thoughts?

MartinHjelmare · 2026-05-11T08:44:56Z

Yeah, do that in a separate PR.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Bump aiotankerkoenig to 0.5.3 (home-assistant#170224) Fix entities refresh for UptimeRobot (home-assistant#170217) Update easyEnergy exception and icon translations (home-assistant#170218) Add more Gen1 sensors to indevolt (home-assistant#170191) Bump letpot to 0.7.0 (home-assistant#169868) Migrate Thermo Beacon to config entry runtime data (home-assistant#170226) Migrate Sensirion BLE to config entry runtime data (home-assistant#170227) Co-authored-by: Josef Zweck <josef@zweck.dev> Bump imgw-pib to 2.1.2 (home-assistant#170274) Bump serialx to 1.7.2 (home-assistant#170272) Bump aioamazondevices to 13.5.0 (home-assistant#170258) Update upb-lib to 0.7.0 (home-assistant#170051) Bump qbittorrent-api to 2026.5.1 (home-assistant#170181) Use VERSION from PrusaLinkConfigFlow in prusalink (home-assistant#170200) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Migrate Duco to python-duco-connectivity and remove temperature sensors (home-assistant#170237) fix: Do not forget segments from state when a new config arrives (home-assistant#170265) Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Complete icon translations for Indevolt (home-assistant#170292) Align Indevolt quality scale with documentation (home-assistant#170289) Apply strict typing to Indevolt integration (home-assistant#170288) iaqualink: set system specific polling interval (home-assistant#170279) Use standby for HDMI-CEC turn off (home-assistant#170206) prusalink: add continue-job button for ATTENTION state (home-assistant#170193) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> data grand lyon: implement diagnostics (home-assistant#170184) Set serial port description from `description`, not `product` (home-assistant#170160) Co-authored-by: Paulus Schoutsen <balloob@gmail.com> Update infrared-protocols to 4.0.0 (home-assistant#170297) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> data grand lyon: use test fixture instead of manual patching (home-assistant#170294) Handle empty BSB-LAN heating circuits (home-assistant#170249) Add diagnostics platform to Home Assistant Connect ZBT-2 (home-assistant#170158) Fix deprecated_class to work with inheritance (home-assistant#170137) Skip offline devices instead of aborting ViCare diagnostics (home-assistant#170106) Fix local API incorrectly marking devices as unavailable in Overkiz (home-assistant#170118) Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io> Add RepairsFlowResult TypeAlias (home-assistant#170263) Fix flaky diagnostics test for Novy Cooker Hood (home-assistant#170299) Fix spelling of RS-232 in Denon RS-232 integration (home-assistant#170298) data grand lyon: implement reconfiguration flow (home-assistant#170210) Add shared test mocks for the Infrared integration (home-assistant#170296) Co-authored-by: Claude <noreply@anthropic.com> Bump renault-api to 0.5.8 (home-assistant#170309) Bump indevolt api to 1.7.2 (home-assistant#170310) Update IQS to platinum for UptimeRobot (home-assistant#170260) Add player specific sensor to nintendo_parental_controls (home-assistant#155786) Co-authored-by: Joshua Peisach (ItzSwirlz) <itzswirlz2020@outlook.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Erik Montnemery <erik@montnemery.com> Fix hassio.backup_partial AttributeError when folders are specified (home-assistant#170312) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Add backoff to forbidden packages (home-assistant#170242) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Add tuya water timer data points (home-assistant#170314) Add more entities for Tuya camera (home-assistant#169966) Co-authored-by: mik-laj <12058428+mik-laj@users.noreply.github.com> Co-authored-by: Norbert Rittel <norbert@rittel.de> Add Tuya DLQ fixture (home-assistant#169585) Update rf-protocols to 3.0.0 (home-assistant#170301) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Add Message Expire Interval option to MQTT publish service (home-assistant#169317) Co-authored-by: Copilot <copilot@github.com> Add new CentriConnect component (home-assistant#166933) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Watts: add HVAC action + preset mode (home-assistant#169546) Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Joostlek <joostlek@outlook.com> Add quality scale for airnow integration (home-assistant#169709) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Fix nobo_hub NoboProfileSelector class-level mutable defaults (home-assistant#170119) Add cover support to control4 (home-assistant#169417) Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> Add Mitsubishi brand (home-assistant#169924) Co-authored-by: Nikolai Rahimi <nikolairahimi@users.noreply.github.com> Co-authored-by: Paulus Schoutsen <balloob@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Fix coordinator data mutation in YouTube diagnostics (home-assistant#170300) Co-authored-by: FIls0010 <a1867444@adelaide.edu.au> Bump aiovodafone to 3.2.0 (home-assistant#170322) Add countdown number for Tuya sfkzq single-valve timers (home-assistant#170318) Allow setting hvac_mode in generic_thermostat.set_temperature (home-assistant#168062) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> Z-Wave.me: Allow updating entities (home-assistant#167839) Fix MQTT device discovery not using shared QoS and encoding options (home-assistant#170195) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Google assistant temperature setting active thermostat mode (home-assistant#166448) Co-authored-by: Lucas Sanchez Sagrado <lucas.sansag@educa.jcyl.es> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Add quality scale to Tesla Fleet integration (home-assistant#160475) Co-authored-by: Claude <noreply@anthropic.com> Only use SmartThings switch for light if it should (home-assistant#166424) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Add quality scale file to Ness Alarm (home-assistant#163425) Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> Fix Shelly media player availability (home-assistant#170319) Update discovery description wording (home-assistant#170325) Bump teltasync to 0.3.0, fix discovery for older devices (home-assistant#169660) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Complete exception translations for Indevolt (home-assistant#170291) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Add Kiosker switch platform (home-assistant#168858) Add `ZWaveNodeBaseEntity` for Z-Wave node-level entities (home-assistant#170124) Add number platform to eurotronic_cometblue (home-assistant#168119) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…ome-assistant#170312) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings May 11, 2026 08:18

home-assistant Bot added bugfix cla-signed core has-tests integration: hassio by-code-owner Quality Scale: internal labels May 11, 2026

Copilot started reviewing on behalf of agners May 11, 2026 08:19 View session

Copilot AI reviewed May 11, 2026

View reviewed changes

Comment thread homeassistant/components/hassio/services.py

Comment thread homeassistant/components/hassio/services.py Outdated

Comment thread tests/components/hassio/test_init.py

agners and others added 3 commits May 11, 2026 10:29

Rename _normalize_partial_backup_data to _normalize_partial_options_data

050acd8

The helper is used by both partial backup and partial restore handlers, so the previous name was misleading. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

MartinHjelmare requested changes May 11, 2026

View reviewed changes

Comment thread homeassistant/components/hassio/services.py Outdated

home-assistant Bot marked this pull request as draft May 11, 2026 08:35

agners added this to the 2026.5.2 milestone May 11, 2026

agners requested review from MartinHjelmare and Copilot May 11, 2026 08:51

agners marked this pull request as ready for review May 11, 2026 08:52

Copilot started reviewing on behalf of agners May 11, 2026 08:52 View session

Copilot AI reviewed May 11, 2026

View reviewed changes

MartinHjelmare approved these changes May 11, 2026

View reviewed changes

MartinHjelmare merged commit 6d8b010 into dev May 11, 2026
89 of 90 checks passed

MartinHjelmare deleted the fix/hassio-partial-backup-folders branch May 11, 2026 10:10

agners mentioned this pull request May 11, 2026

Deprecate legacy "homeassistant" entry in hassio backup/restore folders #170317

Merged

21 tasks

lmaertin pushed a commit to lmaertin/homeassistant-core that referenced this pull request May 11, 2026

Fix hassio.backup_partial AttributeError when folders are specified (h…

109473e

…ome-assistant#170312) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

github-actions Bot locked and limited conversation to collaborators May 12, 2026

frenck added the cherry-picked label May 15, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix hassio.backup_partial AttributeError when folders are specified#170312

Fix hassio.backup_partial AttributeError when folders are specified#170312
MartinHjelmare merged 5 commits into
devfrom
fix/hassio-partial-backup-folders

agners commented May 11, 2026 •

edited

Loading

Uh oh!

home-assistant Bot commented May 11, 2026

Uh oh!

agners commented May 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

home-assistant Bot commented May 11, 2026

Uh oh!

MartinHjelmare commented May 11, 2026

Uh oh!

agners commented May 11, 2026

Uh oh!

MartinHjelmare commented May 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

agners commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking change

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant Bot commented May 11, 2026

Uh oh!

agners commented May 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

home-assistant Bot commented May 11, 2026

Uh oh!

MartinHjelmare commented May 11, 2026

Uh oh!

agners commented May 11, 2026

Uh oh!

MartinHjelmare commented May 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

agners commented May 11, 2026 •

edited

Loading