Add player specific sensor to nintendo_parental_controls by pantherale0 · Pull Request #155786 · home-assistant/core

pantherale0 · 2025-11-04T12:42:43Z

Proposed change

This PR adds a sensor for player specific usage information.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

JPeisach · 2025-11-06T14:27:53Z

-SENSOR_DESCRIPTIONS: tuple[NintendoParentalControlsSensorEntityDescription, ...] = (
-    NintendoParentalControlsSensorEntityDescription(
+@dataclass(kw_only=True, frozen=True)
+class NintendoParentalControlsPlayerSensorEntityDescription(SensorEntityDescription):


Does the naming scheme have to follow this or could it be shortened?

I've named it like this to follow the rest of the naming scheme for other entities. Long, but I need to be able to pass the translation placeholder for the account name.

Co-authored-by: Joshua Peisach (ItzSwirlz) <itzswirlz2020@outlook.com>

home-assistant · 2025-11-21T23:12:55Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

pantherale0 · 2025-12-08T21:13:09Z

Just putting a note here to say I've not forgotten about this - I need to do some more work to ensure that the library consistently collects all players as currently they disappear if "not seen" in a day.

…ontrols sensor setup

pantherale0 · 2025-12-09T20:19:49Z

+        self.entity_description = description
+        self.player_id = player
+        self._attr_translation_placeholders = {
+            "nickname": device.get_player(player).nickname  # type: ignore[dict-item]


I've had to add the type: ignore[dict-item] comment here because for some reason, even if I check TYPE_CHECKING and assert that the value is not None, mypy still throws the same error seen in https://github.com/home-assistant/core/actions/runs/20076931911/job/57593832276

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Stale

emontnemery

LGTM

Can be merged once CI passes.

Bump aiotankerkoenig to 0.5.3 (home-assistant#170224) Fix entities refresh for UptimeRobot (home-assistant#170217) Update easyEnergy exception and icon translations (home-assistant#170218) Add more Gen1 sensors to indevolt (home-assistant#170191) Bump letpot to 0.7.0 (home-assistant#169868) Migrate Thermo Beacon to config entry runtime data (home-assistant#170226) Migrate Sensirion BLE to config entry runtime data (home-assistant#170227) Co-authored-by: Josef Zweck <josef@zweck.dev> Bump imgw-pib to 2.1.2 (home-assistant#170274) Bump serialx to 1.7.2 (home-assistant#170272) Bump aioamazondevices to 13.5.0 (home-assistant#170258) Update upb-lib to 0.7.0 (home-assistant#170051) Bump qbittorrent-api to 2026.5.1 (home-assistant#170181) Use VERSION from PrusaLinkConfigFlow in prusalink (home-assistant#170200) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Migrate Duco to python-duco-connectivity and remove temperature sensors (home-assistant#170237) fix: Do not forget segments from state when a new config arrives (home-assistant#170265) Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Complete icon translations for Indevolt (home-assistant#170292) Align Indevolt quality scale with documentation (home-assistant#170289) Apply strict typing to Indevolt integration (home-assistant#170288) iaqualink: set system specific polling interval (home-assistant#170279) Use standby for HDMI-CEC turn off (home-assistant#170206) prusalink: add continue-job button for ATTENTION state (home-assistant#170193) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> data grand lyon: implement diagnostics (home-assistant#170184) Set serial port description from `description`, not `product` (home-assistant#170160) Co-authored-by: Paulus Schoutsen <balloob@gmail.com> Update infrared-protocols to 4.0.0 (home-assistant#170297) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> data grand lyon: use test fixture instead of manual patching (home-assistant#170294) Handle empty BSB-LAN heating circuits (home-assistant#170249) Add diagnostics platform to Home Assistant Connect ZBT-2 (home-assistant#170158) Fix deprecated_class to work with inheritance (home-assistant#170137) Skip offline devices instead of aborting ViCare diagnostics (home-assistant#170106) Fix local API incorrectly marking devices as unavailable in Overkiz (home-assistant#170118) Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io> Add RepairsFlowResult TypeAlias (home-assistant#170263) Fix flaky diagnostics test for Novy Cooker Hood (home-assistant#170299) Fix spelling of RS-232 in Denon RS-232 integration (home-assistant#170298) data grand lyon: implement reconfiguration flow (home-assistant#170210) Add shared test mocks for the Infrared integration (home-assistant#170296) Co-authored-by: Claude <noreply@anthropic.com> Bump renault-api to 0.5.8 (home-assistant#170309) Bump indevolt api to 1.7.2 (home-assistant#170310) Update IQS to platinum for UptimeRobot (home-assistant#170260) Add player specific sensor to nintendo_parental_controls (home-assistant#155786) Co-authored-by: Joshua Peisach (ItzSwirlz) <itzswirlz2020@outlook.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Erik Montnemery <erik@montnemery.com> Fix hassio.backup_partial AttributeError when folders are specified (home-assistant#170312) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Add backoff to forbidden packages (home-assistant#170242) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Add tuya water timer data points (home-assistant#170314) Add more entities for Tuya camera (home-assistant#169966) Co-authored-by: mik-laj <12058428+mik-laj@users.noreply.github.com> Co-authored-by: Norbert Rittel <norbert@rittel.de> Add Tuya DLQ fixture (home-assistant#169585) Update rf-protocols to 3.0.0 (home-assistant#170301) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Add Message Expire Interval option to MQTT publish service (home-assistant#169317) Co-authored-by: Copilot <copilot@github.com> Add new CentriConnect component (home-assistant#166933) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Watts: add HVAC action + preset mode (home-assistant#169546) Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Joostlek <joostlek@outlook.com> Add quality scale for airnow integration (home-assistant#169709) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Fix nobo_hub NoboProfileSelector class-level mutable defaults (home-assistant#170119) Add cover support to control4 (home-assistant#169417) Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> Add Mitsubishi brand (home-assistant#169924) Co-authored-by: Nikolai Rahimi <nikolairahimi@users.noreply.github.com> Co-authored-by: Paulus Schoutsen <balloob@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Fix coordinator data mutation in YouTube diagnostics (home-assistant#170300) Co-authored-by: FIls0010 <a1867444@adelaide.edu.au> Bump aiovodafone to 3.2.0 (home-assistant#170322) Add countdown number for Tuya sfkzq single-valve timers (home-assistant#170318) Allow setting hvac_mode in generic_thermostat.set_temperature (home-assistant#168062) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> Z-Wave.me: Allow updating entities (home-assistant#167839) Fix MQTT device discovery not using shared QoS and encoding options (home-assistant#170195) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Google assistant temperature setting active thermostat mode (home-assistant#166448) Co-authored-by: Lucas Sanchez Sagrado <lucas.sansag@educa.jcyl.es> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Add quality scale to Tesla Fleet integration (home-assistant#160475) Co-authored-by: Claude <noreply@anthropic.com> Only use SmartThings switch for light if it should (home-assistant#166424) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Add quality scale file to Ness Alarm (home-assistant#163425) Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> Fix Shelly media player availability (home-assistant#170319) Update discovery description wording (home-assistant#170325) Bump teltasync to 0.3.0, fix discovery for older devices (home-assistant#169660) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Complete exception translations for Indevolt (home-assistant#170291) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Add Kiosker switch platform (home-assistant#168858) Add `ZWaveNodeBaseEntity` for Z-Wave node-level entities (home-assistant#170124) Add number platform to eurotronic_cometblue (home-assistant#168119) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…ant#155786) Co-authored-by: Joshua Peisach (ItzSwirlz) <itzswirlz2020@outlook.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Erik Montnemery <erik@montnemery.com>

Add a player specific sensor

4445932

home-assistant Bot added cla-signed has-tests integration: nintendo_parental_controls new-feature by-code-owner Quality Scale: bronze labels Nov 4, 2025

pantherale0 mentioned this pull request Nov 4, 2025

HA Core Progress Tracker pantherale0/pynintendoparental#45

Open

JPeisach reviewed Nov 6, 2025

View reviewed changes

pantherale0 and others added 2 commits November 6, 2025 15:25

Update homeassistant/components/nintendo_parental_controls/sensor.py

246299d

Co-authored-by: Joshua Peisach (ItzSwirlz) <itzswirlz2020@outlook.com>

Merge branch 'dev' into nintendo_parental_controls/add_player_sensor

e9d7ef3

joostlek requested changes Nov 21, 2025

View reviewed changes

Comment thread homeassistant/components/nintendo_parental_controls/sensor.py Outdated

Comment thread homeassistant/components/nintendo_parental_controls/sensor.py Outdated

home-assistant Bot marked this pull request as draft November 21, 2025 23:12

Merge branch 'dev' into nintendo_parental_controls/add_player_sensor

66a13ce

Rename async_add_devices to async_add_entities in Nintendo parental c…

f02aa7a

…ontrols sensor setup

pantherale0 mentioned this pull request Dec 9, 2025

Update pynintendoparental to 2.0.0 #158285

Merged

21 tasks

pantherale0 added 4 commits December 9, 2025 11:17

Merge branch 'dev' into nintendo_parental_controls/add_player_sensor

bef5e98

Update player sensors for 2.1.0

9a1e04b

Merge branch 'dev' into nintendo_parental_controls/add_player_sensor

9845be1

mypy fixes

5ae6f36

pantherale0 commented Dec 9, 2025

View reviewed changes

pantherale0 force-pushed the nintendo_parental_controls/add_player_sensor branch from 80a75f8 to 5ae6f36 Compare December 9, 2025 20:36

fix tests

709fe14

pantherale0 marked this pull request as ready for review December 9, 2025 20:54

home-assistant Bot requested a review from joostlek December 9, 2025 20:54

pantherale0 added 3 commits December 16, 2025 19:06

Merge branch 'dev' into nintendo_parental_controls/add_player_sensor

4944d9c

Merge branch 'dev' into nintendo_parental_controls/add_player_sensor

42b88c7

Merge branch 'dev' into nintendo_parental_controls/add_player_sensor

359d378

Copilot AI review requested due to automatic review settings May 8, 2026 09:01

Copilot started reviewing on behalf of pantherale0 May 8, 2026 09:02 View session

Merge branch 'dev' into nintendo_parental_controls/add_player_sensor

f9ed25a

Copilot AI reviewed May 8, 2026

View reviewed changes

Comment thread homeassistant/components/nintendo_parental_controls/sensor.py

pantherale0 added 2 commits May 8, 2026 10:11

update snapshots

5f8276d

rename player to player_id

9b2f980

Copilot AI review requested due to automatic review settings May 8, 2026 09:13

Copilot started reviewing on behalf of pantherale0 May 8, 2026 09:14 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Comment thread homeassistant/components/nintendo_parental_controls/sensor.py Outdated

Potential fix for pull request finding

0e61a48

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 8, 2026 10:45

Copilot started reviewing on behalf of pantherale0 May 8, 2026 10:46 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

fix copilot suggestion

f61fdda

pantherale0 marked this pull request as ready for review May 8, 2026 10:57

Copilot AI review requested due to automatic review settings May 8, 2026 10:57

home-assistant Bot requested a review from emontnemery May 8, 2026 10:57

Copilot started reviewing on behalf of pantherale0 May 8, 2026 10:58 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Merge branch 'dev' into nintendo_parental_controls/add_player_sensor

9fc9288

emontnemery approved these changes May 11, 2026

View reviewed changes

emontnemery merged commit dc9eba3 into home-assistant:dev May 11, 2026
29 checks passed

github-actions Bot locked and limited conversation to collaborators May 12, 2026

Uh oh!

Conversation

pantherale0 commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

JPeisach Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

pantherale0 Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

home-assistant Bot commented Nov 21, 2025

Uh oh!

pantherale0 commented Dec 8, 2025

Uh oh!

pantherale0 Dec 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

emontnemery left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pantherale0 commented Nov 4, 2025 •

edited

Loading