Add quality scale file to Ness Alarm #163425
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,66 @@ | ||||||
| rules: | ||||||
|
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment. Why do we actually iterate twice over all the subentries in binary sensor setup?
Member
There was a problem hiding this comment. Currently the binary sensor is always initalized with False, should that be |
||||||
| # Bronze | ||||||
| action-setup: done | ||||||
|
Member
There was a problem hiding this comment. Sidenote, I am wondering what the best way is to make these services nice, as they currently pick the first entry. Would it make sense to either
(not a blocker for this, but I think just picking the first one is bad) |
||||||
| appropriate-polling: done | ||||||
| brands: done | ||||||
| common-modules: done | ||||||
| config-flow: done | ||||||
| config-flow-test-coverage: done | ||||||
| dependency-transparency: done | ||||||
| docs-actions: done | ||||||
| docs-high-level-description: done | ||||||
| docs-installation-instructions: done | ||||||
| docs-removal-instructions: done | ||||||
| entity-event-setup: done | ||||||
| entity-unique-id: done | ||||||
| has-entity-name: done | ||||||
|
Poshy163 marked this conversation as resolved.
Member
There was a problem hiding this comment.
Suggested change
|
||||||
| runtime-data: done | ||||||
| test-before-configure: done | ||||||
| test-before-setup: done | ||||||
| unique-config-entry: done | ||||||
|
|
||||||
| # Silver | ||||||
| action-exceptions: done | ||||||
|
Member
There was a problem hiding this comment. arming or disarming the alarm is also considered an action
Member
There was a problem hiding this comment. We don't really do error handling for those, so is this true? |
||||||
| config-entry-unloading: done | ||||||
| docs-configuration-parameters: todo | ||||||
| docs-installation-parameters: todo | ||||||
| entity-unavailable: todo | ||||||
| integration-owner: done | ||||||
| log-when-unavailable: todo | ||||||
| parallel-updates: todo | ||||||
| reauthentication-flow: todo | ||||||
| test-coverage: todo | ||||||
|
Member
There was a problem hiding this comment. I think I would recommend to switch from that MockClient to a proper mock where we just use AsyncMocks
Member
There was a problem hiding this comment. More tests in the test_init.py can use |
||||||
|
|
||||||
| # Gold | ||||||
| devices: done | ||||||
|
Member
There was a problem hiding this comment. You can link the binary sensor to the main device via |
||||||
| diagnostics: todo | ||||||
| discovery-update-info: todo | ||||||
| discovery: todo | ||||||
| docs-data-update: todo | ||||||
| docs-examples: todo | ||||||
| docs-known-limitations: todo | ||||||
| docs-supported-devices: todo | ||||||
| docs-supported-functions: todo | ||||||
| docs-troubleshooting: todo | ||||||
| docs-use-cases: todo | ||||||
| dynamic-devices: todo | ||||||
| entity-category: | ||||||
| status: exempt | ||||||
| comment: No entities need a non-default category. | ||||||
| entity-device-class: done | ||||||
| entity-disabled-by-default: todo | ||||||
| entity-translations: | ||||||
| status: exempt | ||||||
| comment: Entities use device name as entity name. | ||||||
| exception-translations: done | ||||||
| icon-translations: | ||||||
| status: exempt | ||||||
| comment: No entity icons are used. | ||||||
| reconfiguration-flow: todo | ||||||
| repair-issues: done | ||||||
| stale-devices: todo | ||||||
|
|
||||||
| # Platinum | ||||||
| async-dependency: todo | ||||||
| inject-websession: todo | ||||||
| strict-typing: todo | ||||||
Uh oh!
There was an error while loading. Please reload this page.