Migrate Thermo Beacon to config entry runtime data#170226
Merged
Merged
Conversation
Contributor
|
Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
b7a4930 to
c9cb96a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to migrate the thermobeacon integration away from the legacy hass.data[DOMAIN] runtime storage pattern to typed ConfigEntry.runtime_data, aligning with current Home Assistant integration patterns.
Changes:
- Introduces a typed
ThermoBeaconConfigEntryalias to enable typedentry.runtime_data. - Updates the integration and sensor platform setup to accept the typed config entry.
- Switches the sensor platform to read the coordinator from
entry.runtime_datainstead ofhass.data.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
homeassistant/components/thermobeacon/__init__.py |
Sets entry.runtime_data during entry setup and updates function signatures to the typed config entry. |
homeassistant/components/thermobeacon/sensor.py |
Uses entry.runtime_data to obtain the coordinator during platform setup. |
homeassistant/components/thermobeacon/model.py |
Adds the typed ThermoBeaconConfigEntry alias for runtime data typing. |
Comments suppressed due to low confidence (1)
homeassistant/components/thermobeacon/init.py:49
- Avoid leaking per-entry coordinator objects: async_unload_entry no longer removes the entry from hass.data even though async_setup_entry stores it there. Either remove the hass.data storage entirely and rely on entry.runtime_data, or restore the hass.data cleanup when unload_platforms succeeds.
"""Unload a config entry."""
return await hass.config_entries.async_unload_platforms(entry, PLATFORMS)
zweckj
requested changes
May 10, 2026
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
zweckj
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
SSIA.
Type of change
Additional information
thermobeaconto useentry.runtime_data#168803Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: