Add shared test mocks for the Infrared integration by balloob · Pull Request #170296 · home-assistant/core

balloob · 2026-05-11T00:33:15Z

Proposed change

Introduce a common.py module under tests/components/infrared/ that exposes MockInfraredEntity and reusable fixture helpers (init_infrared_fixture_helper, mock_infrared_entity_fixture_helper), mirroring the existing pattern used for the radio_frequency integration.

The matching init_infrared / mock_infrared_entity fixtures are registered in the global tests/components/conftest.py so that any integration consuming infrared (e.g. lg_infrared) can pull in the mock without duplicating it.

The lg_infrared test suite previously carried its own copy of MockInfraredEntity and a local fixture; both have been removed in favor of the shared ones, which also lets us drop a setup_infrared helper fixture and simplify the init_integration fixture.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

Generated by Claude Code

Move MockInfraredEntity and related fixtures into a common.py file following the radio_frequency pattern so consuming integrations can share the mocks.

Drop the lg_infrared copy of MockInfraredEntity and reuse the shared mock and fixtures from tests/components/infrared.

home-assistant · 2026-05-11T00:33:21Z

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (infrared) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of infrared can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant mark-draft Mark the pull request as draft.
@home-assistant ready-for-review Remove the draft status from the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign infrared Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant update-branch Update the pull request branch with the base branch.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

home-assistant · 2026-05-11T00:33:21Z

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (lg_infrared) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lg_infrared can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant mark-draft Mark the pull request as draft.
@home-assistant ready-for-review Remove the draft status from the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign lg_infrared Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant update-branch Update the pull request branch with the base branch.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot

Pull request overview

This pull request centralizes Infrared integration test mocks/fixtures so they can be reused by other integrations (e.g., lg_infrared) without duplicating mock entity code.

Changes:

Added shared Infrared test helpers (MockInfraredEntity, setup/add-entity helper functions) under tests/components/infrared/common.py and a shared ENTITY_ID constant.
Registered global init_infrared / mock_infrared_entity fixtures in tests/components/conftest.py.
Updated lg_infrared and infrared tests to use the shared mocks/fixtures and removed local duplicates.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/components/lg_infrared/utils.py	Switches to the shared Infrared `ENTITY_ID` constant.
tests/components/lg_infrared/test_media_player.py	Uses shared `MockInfraredEntity` type import.
tests/components/lg_infrared/test_config_flow.py	Replaces local Infrared setup with shared fixtures (`init_infrared`, `mock_infrared_entity`).
tests/components/lg_infrared/test_button.py	Uses shared `MockInfraredEntity` type import.
tests/components/lg_infrared/conftest.py	Removes local mock entity/fixture and relies on shared Infrared fixtures.
tests/components/infrared/test_init.py	Updates Infrared tests to use shared fixtures and shared `ENTITY_ID`.
tests/components/infrared/common.py	Provides shared mock entity plus reusable async fixture-helper functions.
tests/components/infrared/init.py	Adds a shared Infrared test `ENTITY_ID` constant.
tests/components/conftest.py	Registers global Infrared fixtures mirroring the existing radio-frequency pattern.

MartinHjelmare · 2026-05-11T07:46:02Z

Test failure is unrelated.

Bump aiotankerkoenig to 0.5.3 (home-assistant#170224) Fix entities refresh for UptimeRobot (home-assistant#170217) Update easyEnergy exception and icon translations (home-assistant#170218) Add more Gen1 sensors to indevolt (home-assistant#170191) Bump letpot to 0.7.0 (home-assistant#169868) Migrate Thermo Beacon to config entry runtime data (home-assistant#170226) Migrate Sensirion BLE to config entry runtime data (home-assistant#170227) Co-authored-by: Josef Zweck <josef@zweck.dev> Bump imgw-pib to 2.1.2 (home-assistant#170274) Bump serialx to 1.7.2 (home-assistant#170272) Bump aioamazondevices to 13.5.0 (home-assistant#170258) Update upb-lib to 0.7.0 (home-assistant#170051) Bump qbittorrent-api to 2026.5.1 (home-assistant#170181) Use VERSION from PrusaLinkConfigFlow in prusalink (home-assistant#170200) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Migrate Duco to python-duco-connectivity and remove temperature sensors (home-assistant#170237) fix: Do not forget segments from state when a new config arrives (home-assistant#170265) Co-authored-by: Jan Bouwhuis <jbouwh@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Complete icon translations for Indevolt (home-assistant#170292) Align Indevolt quality scale with documentation (home-assistant#170289) Apply strict typing to Indevolt integration (home-assistant#170288) iaqualink: set system specific polling interval (home-assistant#170279) Use standby for HDMI-CEC turn off (home-assistant#170206) prusalink: add continue-job button for ATTENTION state (home-assistant#170193) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> data grand lyon: implement diagnostics (home-assistant#170184) Set serial port description from `description`, not `product` (home-assistant#170160) Co-authored-by: Paulus Schoutsen <balloob@gmail.com> Update infrared-protocols to 4.0.0 (home-assistant#170297) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> data grand lyon: use test fixture instead of manual patching (home-assistant#170294) Handle empty BSB-LAN heating circuits (home-assistant#170249) Add diagnostics platform to Home Assistant Connect ZBT-2 (home-assistant#170158) Fix deprecated_class to work with inheritance (home-assistant#170137) Skip offline devices instead of aborting ViCare diagnostics (home-assistant#170106) Fix local API incorrectly marking devices as unavailable in Overkiz (home-assistant#170118) Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io> Add RepairsFlowResult TypeAlias (home-assistant#170263) Fix flaky diagnostics test for Novy Cooker Hood (home-assistant#170299) Fix spelling of RS-232 in Denon RS-232 integration (home-assistant#170298) data grand lyon: implement reconfiguration flow (home-assistant#170210) Add shared test mocks for the Infrared integration (home-assistant#170296) Co-authored-by: Claude <noreply@anthropic.com> Bump renault-api to 0.5.8 (home-assistant#170309) Bump indevolt api to 1.7.2 (home-assistant#170310) Update IQS to platinum for UptimeRobot (home-assistant#170260) Add player specific sensor to nintendo_parental_controls (home-assistant#155786) Co-authored-by: Joshua Peisach (ItzSwirlz) <itzswirlz2020@outlook.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Erik Montnemery <erik@montnemery.com> Fix hassio.backup_partial AttributeError when folders are specified (home-assistant#170312) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Add backoff to forbidden packages (home-assistant#170242) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Add tuya water timer data points (home-assistant#170314) Add more entities for Tuya camera (home-assistant#169966) Co-authored-by: mik-laj <12058428+mik-laj@users.noreply.github.com> Co-authored-by: Norbert Rittel <norbert@rittel.de> Add Tuya DLQ fixture (home-assistant#169585) Update rf-protocols to 3.0.0 (home-assistant#170301) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Add Message Expire Interval option to MQTT publish service (home-assistant#169317) Co-authored-by: Copilot <copilot@github.com> Add new CentriConnect component (home-assistant#166933) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Watts: add HVAC action + preset mode (home-assistant#169546) Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Joostlek <joostlek@outlook.com> Add quality scale for airnow integration (home-assistant#169709) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Fix nobo_hub NoboProfileSelector class-level mutable defaults (home-assistant#170119) Add cover support to control4 (home-assistant#169417) Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> Add Mitsubishi brand (home-assistant#169924) Co-authored-by: Nikolai Rahimi <nikolairahimi@users.noreply.github.com> Co-authored-by: Paulus Schoutsen <balloob@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Fix coordinator data mutation in YouTube diagnostics (home-assistant#170300) Co-authored-by: FIls0010 <a1867444@adelaide.edu.au> Bump aiovodafone to 3.2.0 (home-assistant#170322) Add countdown number for Tuya sfkzq single-valve timers (home-assistant#170318) Allow setting hvac_mode in generic_thermostat.set_temperature (home-assistant#168062) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> Z-Wave.me: Allow updating entities (home-assistant#167839) Fix MQTT device discovery not using shared QoS and encoding options (home-assistant#170195) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Google assistant temperature setting active thermostat mode (home-assistant#166448) Co-authored-by: Lucas Sanchez Sagrado <lucas.sansag@educa.jcyl.es> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Add quality scale to Tesla Fleet integration (home-assistant#160475) Co-authored-by: Claude <noreply@anthropic.com> Only use SmartThings switch for light if it should (home-assistant#166424) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Add quality scale file to Ness Alarm (home-assistant#163425) Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> Fix Shelly media player availability (home-assistant#170319) Update discovery description wording (home-assistant#170325) Bump teltasync to 0.3.0, fix discovery for older devices (home-assistant#169660) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Complete exception translations for Indevolt (home-assistant#170291) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Add Kiosker switch platform (home-assistant#168858) Add `ZWaveNodeBaseEntity` for Z-Wave node-level entities (home-assistant#170124) Add number platform to eurotronic_cometblue (home-assistant#168119) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…0296) Co-authored-by: Claude <noreply@anthropic.com>

- Remove local MockInfraredEntity class and fixtures - Use global init_infrared and mock_infrared_entity fixtures - Simplify conftest.py by removing redundant setup code - Import ENTITY_ID from tests.components.infrared - Import MockInfraredEntity from tests.components.infrared.common

claude added 2 commits May 11, 2026 00:28

Add common.py with infrared test mocks for reuse

247a967

Move MockInfraredEntity and related fixtures into a common.py file following the radio_frequency pattern so consuming integrations can share the mocks.

Use shared infrared test mocks in lg_infrared

0d04195

Drop the lg_infrared copy of MockInfraredEntity and reuse the shared mock and fixtures from tests/components/infrared.

Copilot AI review requested due to automatic review settings May 11, 2026 00:33

balloob requested a review from a team as a code owner May 11, 2026 00:33

home-assistant Bot added code-quality core has-tests integration: infrared integration: lg_infrared small-pr PRs with less than 30 lines. labels May 11, 2026

home-assistant Bot added Quality Scale: internal Quality Scale: silver labels May 11, 2026

Copilot started reviewing on behalf of balloob May 11, 2026 00:34 View session

Fix import order in lg_infrared test_button

272408e

Copilot AI reviewed May 11, 2026

View reviewed changes

balloob mentioned this pull request May 11, 2026

Add Samsung Infrared integration #170269

Closed

21 tasks

MartinHjelmare approved these changes May 11, 2026

View reviewed changes

MartinHjelmare merged commit af41b70 into dev May 11, 2026
79 of 82 checks passed

MartinHjelmare deleted the claude/add-infrared-test-mocks-m8mQD branch May 11, 2026 07:46

lmaertin pushed a commit to lmaertin/homeassistant-core that referenced this pull request May 11, 2026

Add shared test mocks for the Infrared integration (home-assistant#17…

1525f3a

…0296) Co-authored-by: Claude <noreply@anthropic.com>

github-actions Bot locked and limited conversation to collaborators May 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add shared test mocks for the Infrared integration#170296

Add shared test mocks for the Infrared integration#170296
MartinHjelmare merged 3 commits into
devfrom
claude/add-infrared-test-mocks-m8mQD

balloob commented May 11, 2026

Uh oh!

home-assistant Bot commented May 11, 2026

Uh oh!

home-assistant Bot commented May 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

MartinHjelmare commented May 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

balloob commented May 11, 2026

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant Bot commented May 11, 2026

Uh oh!

home-assistant Bot commented May 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

MartinHjelmare commented May 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants