Supervisor issues update retries on failure by mdegat01 · Pull Request #113373 · home-assistant/core

mdegat01 · 2024-03-14T02:53:27Z

Proposed change

The supervisor component's issues manager only does a wholesale update of issues from supervisor at two times:

When core starts
When supervisor restarts

If that call fails then its cache is permanently out of date as all updates after that are done via events. This adds a retry loop to that call. So in case of failure it keeps trying until it succeeds, ensuring the cache is never stuck permanently out of date.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2024-03-14T02:53:33Z

Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration (hassio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hassio can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign hassio Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

frenck

Thanks, @mdegat01 👍

MartinHjelmare · 2024-03-14T10:09:52Z

        )

-    async def update(self) -> None:
+    async def update(self, _: datetime | None = None) -> None:


Maybe it's too late, but I'd consider making this method protected to avoid outside usage that could spawn multiple retries in the same time span.

Alternatively we could cancel any already scheduled retry before scheduling a new one.

Hm yea good call. I'll make a PR for that

…to v2024.3.1 (#437) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/home-assistant/home-assistant](https://www.home-assistant.io/) ([source](https://github.com/home-assistant/core)) | patch | `2024.3.0` -> `2024.3.1` | --- ### Release Notes <details> <summary>home-assistant/core (ghcr.io/home-assistant/home-assistant)</summary> ### [`v2024.3.1`](https://github.com/home-assistant/core/releases/tag/2024.3.1) [Compare Source](home-assistant/core@2024.3.0...2024.3.1) - Fix optional Jellyfin RunTimeTicks ([@j-stienstra] - [#108254]) ([jellyfin docs]) - Add auto fan mode icon ([@mattmccormack] - [#110185]) ([climate docs]) - Ignore AussieBroadband services that don't support usage information ([@FieldofClay] - [#110253]) ([aussie_broadband docs]) - Use friendly name for camera media source ([@OnFreund] - [#110882]) ([camera docs]) - Improve discovering upnp/igd device by always using the SSDP-discovery for the Unique Device Name ([@StevenLooman] - [#111487]) ([upnp docs]) - Update the numato-gpio dependency of the numato integration to v0.12.0 ([@clssn] - [#112272]) ([numato docs]) (dependency) - Disable updating ZHA coordinator path from discovery info ([@puddly] - [#112415]) ([zha docs]) (breaking-change) - Bump intents to 2024.3.6 ([@synesthesiam] - [#112515]) ([conversation docs]) (dependency) - Weatherflow_cloud backing lib bump ([@jeeftor] - [#112262]) ([weatherflow_cloud docs]) (dependency) - Bump weatherflow4py to 0.1.14 ([@jeeftor] - [#112554]) ([weatherflow_cloud docs]) - Restore the juicenet integration ([@emontnemery] - [#112578]) ([juicenet docs]) (new-platform) - Fix incorrect filtering of unsupported locales in bring-api ([@tr4nt0r] - [#112589]) ([bring docs]) - Include pytedee_async logger in tedee integration ([@zweckj] - [#112590]) ([tedee docs]) - Issue warning modbus configuration when modbus configuration is empty ([@janiversen] - [#112618]) ([modbus docs]) - modbus scan_interval: 0 is correct configuration ([@janiversen] - [#112619]) ([modbus docs]) - Update frontend to [`2024030`](https://github.com/home-assistant/core/commit/20240307).0 ([@bramkragten] - [#112620]) ([frontend docs]) - Make hass-nabucasa a core requirement ([@emontnemery] - [#112623]) - Bump aioautomower to 2024.3.0 ([@Thomas55555] - [#112627]) ([husqvarna_automower docs]) (dependency) - Bump pymodbus to v3.6.5 ([@janiversen] - [#112629]) ([modbus docs]) (dependency) - Bump axis to v52 ([@Kane610] - [#112632]) ([axis docs]) (dependency) - Update Loqed helper for more logging ([@mikewoudenberg] - [#112646]) ([loqed docs]) (dependency) - Bump weatherflow4py to 0.1.17 ([@jeeftor] - [#112661]) ([weatherflow_cloud docs]) - Bump `aionotion` to 2024.03.0 ([@bachya] - [#112675]) ([notion docs]) - Make sure Notion saves new refresh token upon startup ([@bachya] - [#112676]) ([notion docs]) - Fix tado climate service ([@alinbalutoiu] - [#112686]) ([tado docs]) - Downgrade `pysnmp-lextudio` to version `5.0.34` ([@bieniu] - [#112696]) ([snmp docs]) (dependency) - Allow duplicate names in different modbus entities ([@janiversen] - [#112701]) ([modbus docs]) - Guard against db corruption when renaming entities ([@bdraco] - [#112718]) ([recorder docs]) - Fix local calendar handling of empty recurrence ids ([@allenporter] - [#112745]) ([calendar docs]) ([local_calendar docs]) - Bump pyenphase to 1.19.2 ([@catsmanac] - [#112747]) ([enphase_envoy docs]) (dependency) - Bump bthome-ble to 3.7.0 ([@thecode] - [#112783]) ([bthome docs]) (dependency) - Upgrade `pysnmp-lextudio` to version `6.0.9` ([@lextm] - [#112795]) ([snmp docs]) (dependency) - Bump openwrt-luci-rpc version to 1.1.17 ([@mrchi] - [#112796]) ([luci docs]) (dependency) - Fix google_asssistant sensor state reporting ([@jbouwh] - [#112838]) ([google_assistant docs]) - Fix MJPEG fallback when still image URL is missing with basic auth ([@bdraco] - [#112861]) ([mjpeg docs]) - Bump boschshcpy to 0.2.82 ([@FlyingFeng2021] - [#112890]) ([bosch_shc docs]) - Add missing translation placeholder in Hydrawise ([@dknowles2] - [#113007]) ([hydrawise docs]) - Bump bthome-ble to 3.8.0 ([@Ernst79] - [#113008]) ([bthome docs]) (dependency) - Bump axis to v53 ([@Kane610] - [#113019]) ([axis docs]) (dependency) - Fix availability for GIOS index sensors ([@bieniu] - [#113021]) ([gios docs]) - Bump ical to 7.0.1 and always use home assistant timezone for local todo dtstart ([@allenporter] - [#113034]) ([google docs]) ([local_calendar docs]) ([local_todo docs]) (dependency) - Fix some handle leaks in rainforest_raven ([@cottsay] - [#113035]) ([rainforest_raven docs]) - Fix hvac_mode for viessmann devices with heatingCooling mode ([@folke] - [#113054]) ([vicare docs]) - components/gardena_bluetooth: Improve avaliability reliability ([@alistair23] - [#113056]) ([gardena_bluetooth docs]) - Fix for controlling Hue switch entities ([@marcelveldt] - [#113064]) ([hue docs]) - Bump rova to 0.4.1 ([@LukasdeBoer] - [#113066]) ([rova docs]) (dependency) - Fix colormode attribute on grouped Hue light ([@marcelveldt] - [#113071]) ([hue docs]) - Bump axis to v54 ([@Kane610] - [#113091]) ([axis docs]) - Bump aiodhcpwatcher to 0.8.1 ([@bdraco] - [#113096]) ([dhcp docs]) (dependency) - bump pytedee_async to 0.2.16 ([@zweckj] - [#113135]) ([tedee docs]) (dependency) - Add message from Bad Request errors to HassioAPIError ([@agners] - [#113144]) ([hassio docs]) - Bump intents to 2023.3.12 ([@synesthesiam] - [#113160]) ([conversation docs]) (dependency) - Bump airthings_ble to 0.7.1 ([@LaStrada] - [#113172]) ([airthings_ble docs]) (dependency) - Bump rokuecp to 0.19.2 ([@ctalkington] - [#113198]) ([roku docs]) (dependency) - Bump `brother` library to version `4.0.2` ([@bieniu] - [#113235]) ([brother docs]) (dependency) - Hotfix import error in ZHA for 2024.3.1 patch release ([@frenck] - [#113250]) ([zha docs]) - Fix Twitch auth token refresh ([@jonnybergdahl] - [#112833]) ([twitch docs]) - Fix failing google diagnostics test ([@bdraco] - [#113095]) ([google docs]) - Add diagnostics for IPP ([@ctalkington] - [#113205]) ([ipp docs]) - Apply suggestion failures fail supervisor repair ([@mdegat01] - [#113372]) ([hassio docs]) - Supervisor issues update retries on failure ([@mdegat01] - [#113373]) ([hassio docs]) - Add loggers to Husqvarna Automower ([@Thomas55555] - [#113381]) ([husqvarna_automower docs]) [#108254]: home-assistant/core#108254 [#110185]: home-assistant/core#110185 [#110253]: home-assistant/core#110253 [#110882]: home-assistant/core#110882 [#111133]: home-assistant/core#111133 [#111441]: home-assistant/core#111441 [#111487]: home-assistant/core#111487 [#111648]: home-assistant/core#111648 [#112262]: home-assistant/core#112262 [#112272]: home-assistant/core#112272 [#112415]: home-assistant/core#112415 [#112515]: home-assistant/core#112515 [#112516]: home-assistant/core#112516 [#112554]: home-assistant/core#112554 [#112578]: home-assistant/core#112578 [#112589]: home-assistant/core#112589 [#112590]: home-assistant/core#112590 [#112618]: home-assistant/core#112618 [#112619]: home-assistant/core#112619 [#112620]: home-assistant/core#112620 [#112623]: home-assistant/core#112623 [#112627]: home-assistant/core#112627 [#112629]: home-assistant/core#112629 [#112632]: home-assistant/core#112632 [#112646]: home-assistant/core#112646 [#112661]: home-assistant/core#112661 [#112675]: home-assistant/core#112675 [#112676]: home-assistant/core#112676 [#112686]: home-assistant/core#112686 [#112696]: home-assistant/core#112696 [#112701]: home-assistant/core#112701 [#112718]: home-assistant/core#112718 [#112745]: home-assistant/core#112745 [#112747]: home-assistant/core#112747 [#112783]: home-assistant/core#112783 [#112795]: home-assistant/core#112795 [#112796]: home-assistant/core#112796 [#112833]: home-assistant/core#112833 [#112838]: home-assistant/core#112838 [#112861]: home-assistant/core#112861 [#112890]: home-assistant/core#112890 [#113007]: home-assistant/core#113007 [#113008]: home-assistant/core#113008 [#113019]: home-assistant/core#113019 [#113021]: home-assistant/core#113021 [#113034]: home-assistant/core#113034 [#113035]: home-assistant/core#113035 [#113054]: home-assistant/core#113054 [#113056]: home-assistant/core#113056 [#113064]: home-assistant/core#113064 [#113066]: home-assistant/core#113066 [#113071]: home-assistant/core#113071 [#113091]: home-assistant/core#113091 [#113095]: home-assistant/core#113095 [#113096]: home-assistant/core#113096 [#113135]: home-assistant/core#113135 [#113144]: home-assistant/core#113144 [#113160]: home-assistant/core#113160 [#113172]: home-assistant/core#113172 [#113198]: home-assistant/core#113198 [#113205]: home-assistant/core#113205 [#113235]: home-assistant/core#113235 [#113250]: home-assistant/core#113250 [#113372]: home-assistant/core#113372 [#113373]: home-assistant/core#113373 [#113381]: home-assistant/core#113381 [@Ernst79]: https://github.com/Ernst79 [@FieldofClay]: https://github.com/FieldofClay [@FlyingFeng2021]: https://github.com/FlyingFeng2021 [@Kane610]: https://github.com/Kane610 [@LaStrada]: https://github.com/LaStrada [@LukasdeBoer]: https://github.com/LukasdeBoer [@OnFreund]: https://github.com/OnFreund [@StevenLooman]: https://github.com/StevenLooman [@Thomas55555]: https://github.com/Thomas55555 [@agners]: https://github.com/agners [@alinbalutoiu]: https://github.com/alinbalutoiu [@alistair23]: https://github.com/alistair23 [@allenporter]: https://github.com/allenporter [@bachya]: https://github.com/bachya [@balloob]: https://github.com/balloob [@bdraco]: https://github.com/bdraco [@bieniu]: https://github.com/bieniu [@bramkragten]: https://github.com/bramkragten [@catsmanac]: https://github.com/catsmanac [@clssn]: https://github.com/clssn [@cottsay]: https://github.com/cottsay [@ctalkington]: https://github.com/ctalkington [@dknowles2]: https://github.com/dknowles2 [@emontnemery]: https://github.com/emontnemery [@folke]: https://github.com/folke [@frenck]: https://github.com/frenck [@j-stienstra]: https://github.com/j-stienstra [@janiversen]: https://github.com/janiversen [@jbouwh]: https://github.com/jbouwh [@jeeftor]: https://github.com/jeeftor [@jonnybergdahl]: https://github.com/jonnybergdahl [@lextm]: https://github.com/lextm [@marcelveldt]: https://github.com/marcelveldt [@mattmccormack]: https://github.com/mattmccormack [@mdegat01]: https://github.com/mdegat01 [@mikewoudenberg]: https://github.com/mikewoudenberg [@mrchi]: https://github.com/mrchi [@puddly]: https://github.com/puddly [@synesthesiam]: https://github.com/synesthesiam [@thecode]: https://github.com/thecode [@tr4nt0r]: https://github.com/tr4nt0r [@zweckj]: https://github.com/zweckj [airthings_ble docs]: https://www.home-assistant.io/integrations/airthings_ble/ [aussie_broadband docs]: https://www.home-assistant.io/integrations/aussie_broadband/ [axis docs]: https://www.home-assistant.io/integrations/axis/ [bosch_shc docs]: https://www.home-assistant.io/integrations/bosch_shc/ [bring docs]: https://www.home-assistant.io/integrations/bring/ [brother docs]: https://www.home-assistant.io/integrations/brother/ [bthome docs]: https://www.home-assistant.io/integrations/bthome/ [calendar docs]: https://www.home-assistant.io/integrations/calendar/ [camera docs]: https://www.home-assistant.io/integrations/camera/ [climate docs]: https://www.home-assistant.io/integrations/climate/ [conversation docs]: https://www.home-assistant.io/integrations/conversation/ [dhcp docs]: https://www.home-assistant.io/integrations/dhcp/ [enphase_envoy docs]: https://www.home-assistant.io/integrations/enphase_envoy/ [frontend docs]: https://www.home-assistant.io/integrations/frontend/ [gardena_bluetooth docs]: https://www.home-assistant.io/integrations/gardena_bluetooth/ [gios docs]: https://www.home-assistant.io/integrations/gios/ [google docs]: https://www.home-assistant.io/integrations/google/ [google_assistant docs]: https://www.home-assistant.io/integrations/google_assistant/ [hassio docs]: https://www.home-assistant.io/integrations/hassio/ [hue docs]: https://www.home-assistant.io/integrations/hue/ [husqvarna_automower docs]: https://www.home-assistant.io/integrations/husqvarna_automower/ [hydrawise docs]: https://www.home-assistant.io/integrations/hydrawise/ [ipp docs]: https://www.home-assistant.io/integrations/ipp/ [jellyfin docs]: https://www.home-assistant.io/integrations/jellyfin/ [juicenet docs]: https://www.home-assistant.io/integrations/juicenet/ [kitchen_sink docs]: https://www.home-assistant.io/integrations/kitchen_sink/ [local_calendar docs]: https://www.home-assistant.io/integrations/local_calendar/ [local_todo docs]: https://www.home-assistant.io/integrations/local_todo/ [loqed docs]: https://www.home-assistant.io/integrations/loqed/ [luci docs]: https://www.home-assistant.io/integrations/luci/ [mjpeg docs]: https://www.home-assistant.io/integrations/mjpeg/ [modbus docs]: https://www.home-assistant.io/integrations/modbus/ [notion docs]: https://www.home-assistant.io/integrations/notion/ [numato docs]: https://www.home-assistant.io/integrations/numato/ [rainforest_raven docs]: https://www.home-assistant.io/integrations/rainforest_raven/ [recorder docs]: https://www.home-assistant.io/integrations/recorder/ [roku docs]: https://www.home-assistant.io/integrations/roku/ [rova docs]: https://www.home-assistant.io/integrations/rova/ [snmp docs]: https://www.home-assistant.io/integrations/snmp/ [tado docs]: https://www.home-assistant.io/integrations/tado/ [tedee docs]: https://www.home-assistant.io/integrations/tedee/ [twitch docs]: https://www.home-assistant.io/integrations/twitch/ [upnp docs]: https://www.home-assistant.io/integrations/upnp/ [vicare docs]: https://www.home-assistant.io/integrations/vicare/ [weatherflow_cloud docs]: https://www.home-assistant.io/integrations/weatherflow_cloud/ [zha docs]: https://www.home-assistant.io/integrations/zha/ </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.internal/nrdufour/home-ops/pulls/437 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>

home-assistant Bot added bugfix cla-signed core has-tests integration: hassio small-pr PRs with less than 30 lines. labels Mar 14, 2024

home-assistant Bot added by-code-owner Quality Scale: internal labels Mar 14, 2024

mdegat01 requested review from agners and frenck March 14, 2024 02:53

Supervisor issues update retries on failure

92e4c0e

mdegat01 force-pushed the issues-update-failure-retry branch from 2888877 to 92e4c0e Compare March 14, 2024 02:54

mdegat01 added this to the 2024.3.2 milestone Mar 14, 2024

frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 14, 2024

frenck approved these changes Mar 14, 2024

View reviewed changes

frenck merged commit 5a25349 into dev Mar 14, 2024

frenck deleted the issues-update-failure-retry branch March 14, 2024 09:55

frenck modified the milestones: 2024.3.2, 2024.3.1 Mar 14, 2024

frenck added the cherry-picked label Mar 14, 2024

frenck pushed a commit that referenced this pull request Mar 14, 2024

Supervisor issues update retries on failure (#113373)

6ca837b

frenck mentioned this pull request Mar 14, 2024

2024.3.1 #113249

Merged

MartinHjelmare reviewed Mar 14, 2024

View reviewed changes

mdegat01 mentioned this pull request Mar 14, 2024

Protect SupervisorIssues.update method #113425

Merged

20 tasks

github-actions Bot locked and limited conversation to collaborators Mar 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Supervisor issues update retries on failure#113373

Supervisor issues update retries on failure#113373
frenck merged 1 commit into
devfrom
issues-update-failure-retry

mdegat01 commented Mar 14, 2024

Uh oh!

home-assistant Bot commented Mar 14, 2024

Uh oh!

frenck left a comment

Uh oh!

MartinHjelmare Mar 14, 2024

Uh oh!

MartinHjelmare Mar 14, 2024

Uh oh!

mdegat01 Mar 14, 2024

Uh oh!

mdegat01 Mar 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

mdegat01 commented Mar 14, 2024

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant Bot commented Mar 14, 2024

Uh oh!

frenck left a comment

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare Mar 14, 2024

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare Mar 14, 2024

Choose a reason for hiding this comment

Uh oh!

mdegat01 Mar 14, 2024

Choose a reason for hiding this comment

Uh oh!

mdegat01 Mar 14, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants