Skip to content

Bump brother library to version 4.0.2#113235

Merged
frenck merged 2 commits into
home-assistant:devfrom
bieniu:brother-4.0.1
Mar 13, 2024
Merged

Bump brother library to version 4.0.2#113235
frenck merged 2 commits into
home-assistant:devfrom
bieniu:brother-4.0.1

Conversation

@bieniu
Copy link
Copy Markdown
Member

@bieniu bieniu commented Mar 13, 2024

Breaking change

Proposed change

Bumps brother library version to 4.0.2 to add a timeout for Brother object initialization.

Changelog: bieniu/brother@4.0.0...4.0.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bieniu bieniu added this to the 2024.3.1 milestone Mar 13, 2024
@home-assistant home-assistant Bot added bugfix cla-signed dependency Pull requests marked as a dependency upgrade integration: brother small-pr PRs with less than 30 lines. by-code-owner Quality Scale: platinum labels Mar 13, 2024
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 13, 2024
@bieniu bieniu marked this pull request as draft March 13, 2024 15:59
@bieniu bieniu changed the title Bump brother library to version 4.0.1 Bump brother library to version 4.0.2 Mar 13, 2024
@bieniu bieniu marked this pull request as ready for review March 13, 2024 16:09
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bieniu 👍

../Frenck

@frenck frenck merged commit b47fb68 into home-assistant:dev Mar 13, 2024
frenck pushed a commit that referenced this pull request Mar 13, 2024
Co-authored-by: Maciej Bieniek <478555+bieniu@users.noreply.github.com>
@frenck frenck mentioned this pull request Mar 13, 2024
xeniter pushed a commit to xeniter/core that referenced this pull request Mar 13, 2024
Co-authored-by: Maciej Bieniek <478555+bieniu@users.noreply.github.com>
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 14, 2024
@bieniu bieniu deleted the brother-4.0.1 branch March 16, 2024 13:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix by-code-owner cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade integration: brother Quality Scale: platinum small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Brother Integration not initializing, stopping HA 2024.3 from fully starting

2 participants