Conversation
Since most of the time this call will be a noop since pubnub will be connected we can avoid scheduling a task on the event loop every time it fires
* Use eager task creation for entity platform polling We have lots of places where `async_update` does not suspend and is only a coro because its required to be a coro to run in the event loop * try again
…1591) This one takes ~0.45s on the green
Discovery integrations load a lot earlier when many modules are not yet loaded so they have a lot less overlapping deps dhcp uses scapy which is large to import. I hope one day to replace it with something more lightweight
…11588) `2024-02-26 21:12:28.305 DEBUG (MainThread) [homeassistant.loader] Importing platform samsungtv.config_flow took 1.10s (loaded_executor=False)` This one has a long requirements list
`2024-02-26 21:12:29.792 DEBUG (MainThread) [homeassistant.loader] Importing platform wemo.config_flow took 1.11s (loaded_executor=False)`
Import thread in the executor DEBUG (MainThread) [homeassistant.loader] Importing platform thread.config_flow took 2.92s (loaded_executor=False)
…111585) * ESPHome: Pass through wake_word_phrase from on-device microWakeWord * Bump aioesphomeapi to 23.0.0
* Use an eager task in the update coordinator scheduled refresh We have a lot of places that will not suspend because the refresh function decides it does not need to update. Currently these have to be scheduled on the event loop even though they are a noop. Since _handle_refresh_interval is subclassed in some integrations, I created a dunder wrapper function to avoid integraions subclassing it * fix time fires outside of patch
This saves waiting one iteration of the event loop
`2024-02-26 21:38:00.091 DEBUG (MainThread) [homeassistant.loader] Component usb import took 0.753 seconds (loaded_executor=False)`
Full fix race in removing entities Followup to #110978 now that we can start the task eagerly it completely closes the race window
We can avoid one event loop iteration to start the tasks here.
We can avoid one event loop iteration to start the tasks here
* Remove zeroconf from ssdp after deps This was added in #36277 but is no longer needed since we setup discovery integrations ahead of time to ensure their deps are updated before other integrations can load them * adjust test
* Reduce bootstrap code Adds a SETUP_ORDER const dict which will be used for future refactoring * tweak * fix bad merge
`2024-02-26 21:37:59.325 DEBUG (MainThread) [homeassistant.loader] Component ssdp import took 1.179 seconds (loaded_executor=False)`
* Deprecate Logi Circle integration * Update homeassistant/components/logi_circle/__init__.py Co-authored-by: G Johansson <goran.johansson@shiftit.se> --------- Co-authored-by: G Johansson <goran.johansson@shiftit.se>
frenck
requested review from
a team,
OttoWinter,
OverloadUT,
Swamp-Ig,
bramkragten,
cdce8p,
cgarwood,
davet2001,
edenhaus,
emontnemery,
farmio,
janiversen,
jbouwh,
jesserockz,
marcelveldt,
marvin-w,
mdegat01,
ochlocracy,
robbiet480,
rohankapoorcom,
scop,
teharris1 and
zxdavb
as code owners
marcelveldt
approved these changes
Mar 6, 2024
thecode
approved these changes
Mar 6, 2024
pree
approved these changes
Mar 6, 2024
joostlek
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.