Skip to content

Guard against db corruption when renaming entities#112718

Merged
bdraco merged 11 commits into
devfrom
guard_db_corrupt_rename
Mar 8, 2024
Merged

Guard against db corruption when renaming entities#112718
bdraco merged 11 commits into
devfrom
guard_db_corrupt_rename

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Mar 8, 2024

Proposed change

Guard against db corruption when renaming entities

  • Add a the filter_unique_constraint_integrity_error safeguard to the entity registry rename
  • Add the same safe guard we had in the states meta manager to the statistics meta manager
  • Fix commit before and ensure it works as all our tests ran with a commit interval of zero

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco added this to the 2024.3.1 milestone Mar 8, 2024
@bdraco bdraco requested a review from a team as a code owner March 8, 2024 13:55
@bdraco bdraco marked this pull request as draft March 8, 2024 13:55
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Mar 8, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of recorder can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign recorder Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Comment thread homeassistant/components/recorder/entity_registry.py
Comment thread homeassistant/components/recorder/core.py
Comment thread homeassistant/components/recorder/table_managers/statistics_meta.py
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Mar 8, 2024

looks like new test works on sqlite and fails on maria/postgres

will have to figure out a solution tomorrow

@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Mar 8, 2024

Good news, the safety does work, it was just a race in the test

@bdraco bdraco marked this pull request as ready for review March 8, 2024 21:31
@bdraco bdraco merged commit af6f2a5 into dev Mar 8, 2024
@bdraco bdraco deleted the guard_db_corrupt_rename branch March 8, 2024 21:34
Comment thread tests/components/recorder/test_init.py
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Energy dashboard statistics stop recording, then database corruption (sqlite)

4 participants