Fix tado climate service

[alinbalutoiu]

Breaking change

Proposed change

Fixes a bug in the Tado set climate service which has broken recently: https://github.com/home-assistant/core/pull/107678/files#diff-5a805908fe968cc52b6a08f2e87e981d565d3990d762c770b10980fe74f88641L392-R407

All parameters were optionals, but they've been made required and it causes the service to fail. More details about the failure in #111918

I have tested it locally ony my server and works fine.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Tado Set climate timer service fails #111918 fixes Unable to set Water Heater to climate mode HEAT #112587
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hi @alinbalutoiu

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[home-assistant]

Hey there @chiefdragon, @erwindouna, mind taking a look at this pull request as it has been labeled with an integration (tado) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tado can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign tado Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[home-assistant]

Hi @alinbalutoiu

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[alinbalutoiu]

Looks like I can't sign the CLA as the Home Assistant Github OAuth app integration has reached the rate limit, seeing API rate limit exceeded in the console.

The rate limit seems to reset at Friday, March 8, 2024 10:04:18 AM.

Stale

[erwindouna]

You're very swift in providing a solution. Many thanks and good work @alinbalutoiu!

[erwindouna]

Can you also link #112587? This will auto-close the issue once it's merged by a Core Member.

[alinbalutoiu]

Can you also link #112587? This will auto-close the issue once it's merged by a Core Member.

Sure, I've linked it as well 👍

[MartinHjelmare]

Please address the comment in a new PR. Thanks!

[timdonovanuk]

This issue persists in 2024.3.1 for me. Will detail in the linked issue #112587