Skip to content

Update the numato-gpio dependency of the numato integration to v0.12.0#112272

Merged
thecode merged 2 commits into
home-assistant:devfrom
clssn:update-numato-0.12
Mar 10, 2024
Merged

Update the numato-gpio dependency of the numato integration to v0.12.0#112272
thecode merged 2 commits into
home-assistant:devfrom
clssn:update-numato-0.12

Conversation

@clssn
Copy link
Copy Markdown
Contributor

@clssn clssn commented Mar 4, 2024

Breaking change

None.

Proposed change

Attempt to fix #112101. Update the numato-gpio dependency of the numato integration which fixes an issue with recent devices whose version numbers are not of integer type. See changelog.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot added bugfix cla-signed dependency Pull requests marked as a dependency upgrade integration: numato small-pr PRs with less than 30 lines. by-code-owner Quality Scale: No score labels Mar 4, 2024
@clssn clssn force-pushed the update-numato-0.12 branch from 6aa77ea to 66c7422 Compare March 4, 2024 19:56
Comment thread .devcontainer/devcontainer.json Outdated
@home-assistant home-assistant Bot marked this pull request as draft March 4, 2024 22:51
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Mar 4, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Fulfills a requirement in the PR checklist.
@clssn clssn force-pushed the update-numato-0.12 branch from 66c7422 to 0b13500 Compare March 5, 2024 17:36
@clssn clssn requested a review from thecode March 5, 2024 17:39
@clssn clssn marked this pull request as ready for review March 10, 2024 09:56
@clssn
Copy link
Copy Markdown
Contributor Author

clssn commented Mar 10, 2024

@thecode , I hope I sufficiently addressed your concerns. I'm looking forward to your re-review. Thx!

@thecode thecode added this to the 2024.3.1 milestone Mar 10, 2024
@thecode thecode merged commit 34d316e into home-assistant:dev Mar 10, 2024
@clssn
Copy link
Copy Markdown
Contributor Author

clssn commented Mar 10, 2024

Thanks, that was quick :-D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Homeassistant does not react to Numato USBGPIO32 gpio state changes

3 participants