Apply suggestion failures fail supervisor repair

[mdegat01]

Proposed change

Applying a suggestion in supervisor via repair is still always succeeding even if it failed behind the scenes after #111162 . Appears that is because the apply suggestion API in handler only returns True or False, it never raises. Adjusted code to treat False response as failure and correctly abort the repair when the suggestion fails to apply.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration (hassio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of hassio can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign hassio Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[agners]

Appears that is because the apply suggestion API in handler only returns True or False, it never raises.

Right, the @_api_bool annotation does that.

I am not really sure though if that is a good API 🤔 It is a loss of information in the end. In this particular case, we didn't really do something with the exception information anyways, so your change just fixes things to behave as they should. Now the user actually should get the abort reason Could not apply the fix. Check the Supervisor logs for more details..

But maybe, we should actually consider dropping/changing that annotation and handle exceptions on callee side 🤔 . Then we can do sensible things with the error returned. I guess we can't simply pass the error to the user as we need to translate things. But maybe we can add a few common abort reasons and translate them 🤔

In any case, this should be a follow up PR. This PR fixes things as they are currently intended to work. We should also ship this with the next Core patch release. I see you already added it to the milestone 👍

[mdegat01]

@agners Yes I know. But we have no choice but to drop the information right now because this is for the frontend. We cannot just pass along the error message from Supervisor directly into the UI, we need translation strings. We got away with that in the other PR because it was only used for logging. To change this spot we need to iterate out all the possible messages and make translation strings out of them. So that requires follow up and I'd say isn't in scope for a patch fix.