Skip to content

Upgrade pysnmp-lextudio to version 6.0.9#112795

Merged
bdraco merged 1 commit into
home-assistant:devfrom
lextm:dev
Mar 9, 2024
Merged

Upgrade pysnmp-lextudio to version 6.0.9#112795
bdraco merged 1 commit into
home-assistant:devfrom
lextm:dev

Conversation

@lextm
Copy link
Copy Markdown
Contributor

@lextm lextm commented Mar 9, 2024

Breaking change

Proposed change

Release 6.0.9 adds back certain types that this project relies on.

Changelog: lextudio/pysnmp@v5.0.34...v6.0.9

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@lextm lextm requested a review from a team as a code owner March 9, 2024 03:46
Copy link
Copy Markdown
Contributor

@home-assistant home-assistant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lextm

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant Bot added bugfix cla-needed dependency Pull requests marked as a dependency upgrade integration: snmp small-pr PRs with less than 30 lines. labels Mar 9, 2024
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Mar 9, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@lextm
Copy link
Copy Markdown
Contributor Author

lextm commented Mar 9, 2024

@bieniu @bdraco I wasn't able to set up local testing environment for this pull request, so need some help from you.

@lextm lextm mentioned this pull request Mar 9, 2024
@bdraco
Copy link
Copy Markdown
Member

bdraco commented Mar 9, 2024

Thanks. I started the CI

@lextm lextm marked this pull request as ready for review March 9, 2024 06:07
@Kane610
Copy link
Copy Markdown
Member

Kane610 commented Mar 9, 2024

Please provide a diff of the changes coming with the library bump

@lextm
Copy link
Copy Markdown
Contributor Author

lextm commented Mar 9, 2024

@Kane610 Changelog: lextudio/pysnmp@v5.0.34...v6.0.9

@bieniu
Copy link
Copy Markdown
Member

bieniu commented Mar 9, 2024

I tested brother and snmp sensor integrations, both work properly. I don't have a real devices to test snmp device_tracker and snmp switch.

@khenderick
Copy link
Copy Markdown
Contributor

Comfirm snmp switch works with 6.0.9 👍

@jbouwh
Copy link
Copy Markdown
Contributor

jbouwh commented Mar 9, 2024

Also tested it in my dev env on my switch. Works okay.

Copy link
Copy Markdown
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thnx @lextm 👍

@jbouwh jbouwh added this to the 2024.3.1 milestone Mar 9, 2024
@jbouwh
Copy link
Copy Markdown
Contributor

jbouwh commented Mar 9, 2024

Added a milestone too, not sure if that is possible for this change though.

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Mar 9, 2024

It should cherry pick cleanly on top of #112696

Copy link
Copy Markdown
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with my ups power sensor

@bdraco
Copy link
Copy Markdown
Member

bdraco commented Mar 9, 2024

Thanks @lextm

Great first contribution

@bdraco bdraco merged commit 9974af3 into home-assistant:dev Mar 9, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade integration: snmp Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants