Skip to content

Make sure Notion saves new refresh token upon startup#112676

Merged
balloob merged 9 commits into
home-assistant:devfrom
bachya:notion-save-refresh-token
Mar 9, 2024
Merged

Make sure Notion saves new refresh token upon startup#112676
balloob merged 9 commits into
home-assistant:devfrom
bachya:notion-save-refresh-token

Conversation

@bachya
Copy link
Copy Markdown
Contributor

@bachya bachya commented Mar 8, 2024

Proposed change

SSIA

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Comment thread homeassistant/components/notion/__init__.py Outdated
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bachya The CI is failing, could you take a look? 👍

../Frenck

@home-assistant home-assistant Bot marked this pull request as draft March 8, 2024 10:56
@home-assistant
Copy link
Copy Markdown
Contributor

home-assistant Bot commented Mar 8, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@bachya bachya marked this pull request as ready for review March 8, 2024 16:10
@home-assistant home-assistant Bot requested a review from frenck March 8, 2024 16:10
Comment thread homeassistant/components/notion/__init__.py Outdated
@bachya bachya force-pushed the notion-save-refresh-token branch from a41cd20 to b86166a Compare March 8, 2024 16:39
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🐬

@balloob balloob merged commit 3405bda into home-assistant:dev Mar 9, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants