Skip to content

Downgrade pysnmp-lextudio to version 5.0.34#112696

Merged
balloob merged 1 commit into
home-assistant:devfrom
bieniu:downgrade-pysnmp
Mar 8, 2024
Merged

Downgrade pysnmp-lextudio to version 5.0.34#112696
balloob merged 1 commit into
home-assistant:devfrom
bieniu:downgrade-pysnmp

Conversation

@bieniu
Copy link
Copy Markdown
Member

@bieniu bieniu commented Mar 8, 2024

Breaking change

Proposed change

It appears that some of the code on which SNMP device_tracker is based has been removed from the pysnmp-lextudio library lextudio/pysnmp#52

As a temporary workaround, I suggest downgrading the library to version 5.0.34 as users report that this version works fine. This is a partially revert of #111193

The SNMP device_tracker code needs to be rewritten. Unfortunately, I don't have a compatible device and I'm unable to undertake this task.

Changelog: lextudio/pysnmp@v5.0.34...v6.0.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant Bot added bugfix cla-signed dependency Pull requests marked as a dependency upgrade integration: snmp small-pr PRs with less than 30 lines. Quality Scale: No score labels Mar 8, 2024
@bieniu bieniu added this to the 2024.3.1 milestone Mar 8, 2024
@balloob balloob merged commit 7cbe495 into home-assistant:dev Mar 8, 2024
@bieniu bieniu deleted the downgrade-pysnmp branch March 8, 2024 14:05
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade integration: snmp Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SNMP device tracker broken in 2024.3.0 and Python 3.12

3 participants