Skip to content

Bump ical to 7.0.1 and always use home assistant timezone for local todo dtstart#113034

Merged
balloob merged 1 commit into
home-assistant:devfrom
allenporter:todo-timezone
Mar 11, 2024
Merged

Bump ical to 7.0.1 and always use home assistant timezone for local todo dtstart#113034
balloob merged 1 commit into
home-assistant:devfrom
allenporter:todo-timezone

Conversation

@allenporter
Copy link
Copy Markdown
Contributor

@allenporter allenporter commented Mar 11, 2024

Proposed change

Bump ical to 7.0.1 which fixes a few different todo and timezone bugs. Updated to always use home assistant timezone for local todo dtstart to avoid using misconfigured system timezones for dtstart values.

The fixes in 7.0.1 are fixing issues created in 2023.3 that allowed inconsistencies between dates that break the rfc (now auto repaired) and allowed invalid timezones in dstart.

Release notes: https://github.com/allenporter/ical/releases/tag/7.0.1
Changes: allenporter/ical@7.0.0...7.0.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@balloob balloob merged commit 23f9aea into home-assistant:dev Mar 11, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot load todo list after restart Can't save any new To Do items when system timezone is not valid timezone

3 participants