Fix local calendar handling of empty recurrence ids#112745
Merged
Merged
Conversation
Contributor
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
balloob
approved these changes
Mar 8, 2024
Member
balloob
left a comment
There was a problem hiding this comment.
This works.
I think that we might want to teach the frontend to sent in None instead of empty strings too.
|
OK can someone please let me know what I need to do to get this fixed in home assistant? Seems ticket got marked as fixed but problem still appears in mine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix bug when editing or deleting existing calendar events which fails with:
Error handling Calendar Event call: Unable to parse date/time value: [ValueError("Expected value to match DATE pattern: ''"), ValueError('Expected value to match DATE-TIME pattern: ')]The frontend currently passes in an empty string for the recurrence_id which is then attempted to be parsed as an event id instance. This fixes the schema parser to ignore empty strings and treat them as none.
Alternatives:
Noneexplicitly into the entity APIs.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: