Skip to content

2024.2.5#111648

Merged
balloob merged 2 commits into
masterfrom
rc
Feb 27, 2024
Merged

2024.2.5#111648
balloob merged 2 commits into
masterfrom
rc

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Feb 27, 2024

Translations from the dev branch are included in each release. The above PR introduced a new placeholder into an existing translation. When we released 2024.2.4, it tried to render the new translation without providing the placeholder. Doing a hot fix to provide the placeholder value so this translation works again as the issue is quite visible.

timmo001 and others added 2 commits February 27, 2024 11:48
* Add title to reauthenticate integration issue

* Fix translation placeholder in test

* Update translation placeholders in test_init.py

* Update integration reauthentication message

* Update string
@balloob balloob requested a review from a team as a code owner February 27, 2024 16:50
@home-assistant home-assistant Bot added cla-signed core has-tests integration: kitchen_sink merging-to-master This PR is merging into the master branch and should probably change the branch to `dev`. small-pr PRs with less than 30 lines. labels Feb 27, 2024
@home-assistant
Copy link
Copy Markdown
Contributor

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (kitchen_sink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of kitchen_sink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign kitchen_sink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@balloob balloob merged commit bc47c80 into master Feb 27, 2024
@rytilahti rytilahti mentioned this pull request Feb 28, 2024
@THETCR
Copy link
Copy Markdown

THETCR commented Feb 28, 2024

@balloob The deployment pipeline is still waiting for approval. Any reason why this release has been put on hold?

@garry0garry
Copy link
Copy Markdown

#111516 (comment)

@github-actions github-actions Bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed core has-tests integration: kitchen_sink merging-to-master This PR is merging into the master branch and should probably change the branch to `dev`. Quality Scale: internal small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants