core, repair: migrate port bindings for tests to non-overlapping solution by puhtaytow · Pull Request #7104 · anza-xyz/agave

puhtaytow · 2025-07-23T10:23:16Z

Problem

A bunch of tests still relies on either hardcoded ports or bind_to_localhost and bind_to_unspecified. This creates flaky tests in cases where unique port ranges are needed.

This PR is the step in the journey toward resolving the issue.

Related to #7055

Summary of Changes

Fixed bug with inclusive end port in test_request_repair_for_shred_from_address
Migrated instances across core, repair tests that had in place obsolete bind_to_unspecified

…unique

…o_localhost_unique

…7031)

* clean up naming * accumulates and reports included transaction fees * only collect total prioritization fee

…-xyz#7040) Use Instruction instead of StableInstruction

* move benchmarks to bencher 0.1.5 * use std::hint::black_box where possible

…z#7045) - Ran cargo clippy with Rust 1.88.0 set in rust-toolchain.toml - Ran cargo fmt with format_strings = true in rustfmt.toml

…rs as a trait (anza-xyz#6921)

* runtime: Inline `extend_and_hash` #### Problem `solana_sha256_hasher::extend_and_hash` requires dynamic allocation because of the vec creation, which means adding a `std` feature to the crate. However, the function is only used in one place, so it would be easier to remove it and simplify the hasher crate. #### Summary of changes Inline the usage of `extend_and_hash` so it can be safely removed from the hasher crate. * Simplify extend_and_hash impl

…yz#7035)

…` and `SlotNotEpochBoundaryErrorData` (anza-xyz#6962) * Add `slot` to the error context of `EpochRewardsPeriodActiveErrorData` and `SlotNotEpochBoundaryErrorData` * Add CHANGELOG entries * Directly serialize the JSON-RPC error data, rather than bouncing it through a struct * Make `EpochRewardsPeriodActiveErrorData` from the perspective of deserializing _old_ data by making `slot` an Option

…a-xyz#6516) * Don't construct or notify `RpcSubscriptions` when the RPC is off * Less dumb Rust * Keep going? Can't get it to typecheck. * Revert some places that still need `Arc`s due to threads * Cleanup tests, avoid a clone in tpu --------- Co-authored-by: Jon C <me@jonc.dev>

move benchmarks to bencher 0.1.5

This function provided a hack to change threadpool sizes to avoid observed performance issues. The users of this function have since been updated to have CLI args wired up to control the threadpool sizes. So, the hack is no longer necessary and can be deprecated

* move verify_args_struct_by_command_run_with_no_genesis_fetch() * move verify_args_struct_by_command_run_with_no_snapshot_fetch * move verify_args_struct_by_command_run_with_check_vote_account * move verify_args_struct_by_command_run_with_only_known_rpc * move verify_args_struct_by_command_run_with_incremental_snapshot_fetch * wording

…#7086) SnapshotConfig has a non-trivial amount of arguments, operations and checks that occur. Shift all of this logic into a side function to help organize and de-clutter

* build(deps): bump io-uring from 0.7.8 to 0.7.9 Bumps [io-uring](https://github.com/tokio-rs/io-uring) from 0.7.8 to 0.7.9. - [Commits](https://github.com/tokio-rs/io-uring/commits) --- updated-dependencies: - dependency-name: io-uring dependency-version: 0.7.9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update all Cargo files --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

A default function is certainly useful for tests to avoid tons of copy/paste. However, we should avoid it in production code to reduce the chance of accidental misconfiguration or forgetting to update somewhere

…ata_direct_mapping` (anza-xyz#7056) * Reverts the disabling of enable_stack_frame_gaps in bpf_account_data_direct_mapping. * Adjusts test_stack_heap_zeroed.

A Default impl for this config struct is a potential footgun; we should be explicitly specifying all fields in production code. Note that the default_for_test() function is left as-is to avoid copy/past in tests

* add sort workspace to cargo fmt script * remove obsolete formatting script

…dditionalDataV2 (anza-xyz#7118) Remove deprecated AccountAdditionalData and AccountAdditionalDataV2

accounts-db: Remove deprecated is_hash_valid()

…yz#7097) The merkle_variant parameter has been removed as well

mergify · 2025-07-24T15:23:44Z

If this PR represents a change to the public RPC API:

Make sure it includes a complementary update to rpc-client/ (example)
Open a follow-up PR to update the JavaScript client @solana/kit (example)

Thank you for keeping the RPC clients in sync with the server API @puhtaytow.

mergify · 2025-07-24T15:23:44Z

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

mergify · 2025-07-24T15:23:45Z

For your information, the zk-keygen and zk-sdk directories are
scheduled to be relocated to solana-program/zk-elgamal-proof in a
separate repository. Additionally, the zk-token-sdk directory will
be removed. Please take these upcoming changes into account when
making modifications.

puhtaytow added 2 commits July 21, 2025 08:52

port helper functions

56aa2d4

move Ipv4Addr import to global scope

8d86cec

puhtaytow marked this pull request as draft July 23, 2025 10:23

mergify Bot added community need:merge-assist labels Jul 23, 2025

mergify Bot requested a review from a team July 23, 2025 10:23

core, repair service: swap old bind_to, to the new bind_to_localhost_…

a9477ae

…unique

puhtaytow force-pushed the core-repair-service-replace-bind-to-0 branch from 6566be3 to a9477ae Compare July 23, 2025 10:45

puhtaytow changed the title ~~core, repair service: swap bind_to to new bind_to_localhost_unique~~ WIP: swap old bind_to, to the new bind_to_localhost_unique Jul 23, 2025

core, repair service: swap old bind_to_unspecified, to the new bind_t…

65aca80

…o_localhost_unique

puhtaytow changed the title ~~WIP: swap old bind_to, to the new bind_to_localhost_unique~~ WIP: migrate old port bindings for tests Jul 23, 2025

core, repair: migrate ancestor hashes service to new binding for tests

4eea234

puhtaytow changed the title ~~WIP: migrate old port bindings for tests~~ core, repair: WIP / migrate old port bindings for tests Jul 23, 2025

puhtaytow changed the title ~~core, repair: WIP / migrate old port bindings for tests~~ core, repair: migrate port bindings for tests Jul 23, 2025

puhtaytow changed the title ~~core, repair: migrate port bindings for tests~~ core, repair: migrate port bindings for tests to non-overlapping solution Jul 23, 2025

puhtaytow marked this pull request as ready for review July 24, 2025 14:36

puhtaytow marked this pull request as draft July 24, 2025 14:39

steveluscher and others added 13 commits July 24, 2025 17:16

Subscription requests now take priority over notifications (anza-xyz#…

64e63c0

…7031)

block-prioritization-fee metrics update (anza-xyz#6967)

dad4468

* clean up naming * accumulates and reports included transaction fees * only collect total prioritization fee

Use Instruction instead of StableInstruction across runtime (anza…

9b7714d

…-xyz#7040) Use Instruction instead of StableInstruction

metrics: move benchmarks to bencher 0.1.5 (anza-xyz#7011)

281e13a

* move benchmarks to bencher 0.1.5 * use std::hint::black_box where possible

net-utils: Resolve Rust 1.88 clippy lints and format strings (anza-xy…

831d660

…z#7045) - Ran cargo clippy with Rust 1.88.0 set in rust-toolchain.toml - Ran cargo fmt with format_strings = true in rustfmt.toml

Capture ability of BufferedReader to provide contiguous min len buffe…

0663334

…rs as a trait (anza-xyz#6921)

refactor: remove unused parameter to CostUpdateService (anza-xyz#7048)

ef9453e

Removes merkle-based accounts hashing in AccountsHashVerifier (anza-x…

eb9ef9a

…yz#7035)

refactor - remove wrapper function (anza-xyz#7059)

ca91a37

Removes MerkleOrLatticeAccountsHash enum (anza-xyz#7039)

17a76c4

samkim-crypto and others added 26 commits July 24, 2025 17:16

Downgrade to curve25519-dalek v4.1.3 (anza-xyz#7079)

6188a3d

perf: move benchmarks to bencher 0.1.5 (anza-xyz#7041)

eb4c2c8

move benchmarks to bencher 0.1.5

validator: Move SnapshotConfig parsing to separate function (anza-xyz…

ad6df91

…#7086) SnapshotConfig has a non-trivial amount of arguments, operations and checks that occur. Shift all of this logic into a side function to help organize and de-clutter

ledger: Remove deprecated legacy shred functions (anza-xyz#7094)

db5c8ee

Uses Rust's div_ceil() (anza-xyz#7096)

85cd1d9

Removes update_accounts_hash() family of fns (anza-xyz#7091)

526cf8d

svm: test for nonce inspection (anza-xyz#7090)

3ca1e74

validator: Remove use of ValidatorConfig::default() (anza-xyz#7100)

be57238

A default function is certainly useful for tests to avoid tons of copy/paste. However, we should avoid it in production code to reduce the chance of accidental misconfiguration or forgetting to update somewhere

Revert - The disabling of enable_stack_frame_gaps in `bpf_account_d…

53985be

…ata_direct_mapping` (anza-xyz#7056) * Reverts the disabling of enable_stack_frame_gaps in bpf_account_data_direct_mapping. * Adjusts test_stack_heap_zeroed.

Clean up feature: raise_block_limits_to_60m (anza-xyz#7110)

079b37f

Removes calculate_accounts_delta_hash() (anza-xyz#7093)

385d95e

Remove the Default trait impl. for ValidatorConfig (anza-xyz#7101)

3a88a35

A Default impl for this config struct is a potential footgun; we should be explicitly specifying all fields in production code. Note that the default_for_test() function is left as-is to avoid copy/past in tests

Removes AccountsDb::accounts_delta_hash (anza-xyz#7095)

f674c2a

scripts: remove obsolete cargo-fmt.sh (anza-xyz#7036)

b6e27a5

* add sort workspace to cargo fmt script * remove obsolete formatting script

pubsub-client: Remove deprecated set_node_version (anza-xyz#7117)

651dab5

rpc-client: Remove deprecated set_node_version (anza-xyz#7116)

7b3f1ca

account-decoder: Remove deprecated AccountAdditionalData and AccountA…

681e8e3

…dditionalDataV2 (anza-xyz#7118) Remove deprecated AccountAdditionalData and AccountAdditionalDataV2

Removes accounts delta hash (anza-xyz#7112)

354b7bd

accounts-db: Remove deprecated is_hash_valid (anza-xyz#7122)

79c6c05

accounts-db: Remove deprecated is_hash_valid()

Configure more SVM conformace tests (anza-xyz#7121)

a44ceb0

Update more blockstore.rs tests to use merkle shreds (anza-xyz#6163)

700b083

svm tests: add loaderv3 program cache tests (anza-xyz#7050)

753deed

ledger: Update make_slot_entries() to make merkle shreds only (anza-x…

b2dfc62

…yz#7097) The merkle_variant parameter has been removed as well

puhtaytow closed this Jul 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

core, repair: migrate port bindings for tests to non-overlapping solution#7104

core, repair: migrate port bindings for tests to non-overlapping solution#7104
puhtaytow wants to merge 68 commits intoanza-xyz:masterfrom
puhtaytow:core-repair-service-replace-bind-to-0

puhtaytow commented Jul 23, 2025 •

edited

Loading

Uh oh!

mergify Bot commented Jul 24, 2025

Uh oh!

mergify Bot commented Jul 24, 2025

Uh oh!

mergify Bot commented Jul 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

puhtaytow commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Summary of Changes

Uh oh!

mergify Bot commented Jul 24, 2025

Uh oh!

mergify Bot commented Jul 24, 2025

Uh oh!

mergify Bot commented Jul 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

puhtaytow commented Jul 23, 2025 •

edited

Loading