accounts-db: Remove deprecated is_hash_valid#7122
Merged
fkouteib merged 1 commit intoanza-xyz:masterfrom Jul 24, 2025
Merged
Conversation
|
Seems fine. I'm only superficially familiar with the blockhash queue; why are we only removing this now? (Wondering if there's a forcing function, or just optimistic.) |
Author
No Forcing function for this. I don't have the historical context why it stuck around until now. Just a latent cleanup before the 3.0 major release. |
brooksprumo
approved these changes
Jul 23, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7122 +/- ##
========================================
Coverage 83.2% 83.2%
========================================
Files 853 853
Lines 374069 374013 -56
========================================
+ Hits 311467 311512 +45
+ Misses 62602 62501 -101 🚀 New features to boost your workflow:
|
puhtaytow
pushed a commit
to puhtaytow/agave
that referenced
this pull request
Jul 24, 2025
accounts-db: Remove deprecated is_hash_valid()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
is_hash_valid() has been deprecated since 2.0.0
Summary of Changes
Remove deprecated function