Skip to content

accounts-db: Remove deprecated is_hash_valid#7122

Merged
fkouteib merged 1 commit intoanza-xyz:masterfrom
fkouteib:accounts-db_deprecation
Jul 24, 2025
Merged

accounts-db: Remove deprecated is_hash_valid#7122
fkouteib merged 1 commit intoanza-xyz:masterfrom
fkouteib:accounts-db_deprecation

Conversation

@fkouteib
Copy link
Copy Markdown

Problem

is_hash_valid() has been deprecated since 2.0.0

Summary of Changes

Remove deprecated function

@fkouteib fkouteib requested a review from brooksprumo July 23, 2025 23:11
@brooksprumo
Copy link
Copy Markdown

Seems fine. I'm only superficially familiar with the blockhash queue; why are we only removing this now? (Wondering if there's a forcing function, or just optimistic.)

@fkouteib
Copy link
Copy Markdown
Author

Seems fine. I'm only superficially familiar with the blockhash queue; why are we only removing this now? (Wondering if there's a forcing function, or just optimistic.)

No Forcing function for this. I don't have the historical context why it stuck around until now. Just a latent cleanup before the 3.0 major release.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.2%. Comparing base (b6e29bd) to head (9628ae0).
⚠️ Report is 2801 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #7122    +/-   ##
========================================
  Coverage    83.2%    83.2%            
========================================
  Files         853      853            
  Lines      374069   374013    -56     
========================================
+ Hits       311467   311512    +45     
+ Misses      62602    62501   -101     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fkouteib fkouteib merged commit 6f3f76a into anza-xyz:master Jul 24, 2025
41 checks passed
@fkouteib fkouteib deleted the accounts-db_deprecation branch July 24, 2025 00:12
puhtaytow pushed a commit to puhtaytow/agave that referenced this pull request Jul 24, 2025
accounts-db: Remove deprecated is_hash_valid()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants