Removes accounts delta hash#7112
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Jul 23, 2025
Merged
Conversation
brooksprumo
force-pushed
the
lthash/accounts-delta-hash-serde-snapshot
branch
from
d9e16a1 to
8f5e6bf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7112 +/- ##
=======================================
Coverage 83.2% 83.2%
=======================================
Files 853 853
Lines 374075 374048 -27
=======================================
- Hits 311444 311436 -8
+ Misses 62631 62612 -19 🚀 New features to boost your workflow:
|
brooksprumo
force-pushed
the
lthash/accounts-delta-hash-serde-snapshot
branch
from
8f5e6bf to
7c335e7
Compare
brooksprumo
changed the title
brooksprumo
commented
Jul 23, 2025
| feature = "frozen-abi", | ||
| derive(AbiExample), | ||
| frozen_abi(digest = "7F6xtBno4tS6QaD3wP8kQxa9BiRtvmCu8TzFNprFjM7A") | ||
| frozen_abi(digest = "RHixw67oBUdJQn9TLES55Nb4Sr1wuAfo7NTJH56oRxb") |
Author
There was a problem hiding this comment.
The frozen abi digest changed because of the accounts delta hash. I renamed it, and removed the newtype wrappers.
full diff
--- ./bank__serde_snapshot__tests__test_bank_serialize__BankAbiTestWrapper_frozen_abi__test_abi_digest_7F6xtBno4tS6QaD3wP8kQxa9BiRtvmCu8TzFNprFjM7A 2025-07-23 12:58:36
+++ ./bank__serde_snapshot__tests__test_bank_serialize__BankAbiTestWrapper_frozen_abi__test_abi_digest_RHixw67oBUdJQn9TLES55Nb4Sr1wuAfo7NTJH56oRxb 2025-07-23 15:26:08
@@ -1039,74 +1039,72 @@
primitive u64
element solana_runtime::serde_snapshot::BankHashInfo
struct BankHashInfo (fields = 3)
- field accounts_delta_hash: solana_accounts_db::accounts_hash::SerdeAccountsDeltaHash
- struct SerdeAccountsDeltaHash(solana_hash::Hash) (newtype)
- struct Hash([u8; 32]) (newtype)
- tuple (elements = 32)
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
- element u8
- primitive u8
+ field obsolete_accounts_delta_hash: [u8; 32]
+ tuple (elements = 32)
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
+ element u8
+ primitive u8
field accounts_hash: solana_accounts_db::accounts_hash::SerdeAccountsHash
brooksprumo
force-pushed
the
lthash/accounts-delta-hash-serde-snapshot
branch
from
7c335e7 to
598dbfb
Compare
HaoranYi
reviewed
Jul 23, 2025
| bank_hash_stats: BankHashStats, | ||
| accounts_delta_hash: AccountsDeltaHash, // obsolete, will be removed next | ||
| accounts_hash: AccountsHash, // obsolete, will be removed next | ||
| accounts_hash: AccountsHash, // obsolete, will be removed next |
roryharr
approved these changes
Jul 23, 2025
puhtaytow
pushed a commit
to puhtaytow/agave
that referenced
this pull request
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The merkle-based accounts hashing is no longer used.
Summary of Changes
Removes accounts delta hash.