Skip to content

Uses Rust's div_ceil()#7096

Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:lthash/div-ceil
Jul 23, 2025
Merged

Uses Rust's div_ceil()#7096
brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo:lthash/div-ceil

Conversation

@brooksprumo
Copy link
Copy Markdown

Problem

Partitioned epoch rewards uses the AccountsHasher impl of div_ceil(), which we're trying to remove. Also, div_ceil() is now stable in Rust, so we should use that instead and not reimplement our own.

Summary of Changes

Use Rust's div_ceil().

@brooksprumo brooksprumo self-assigned this Jul 23, 2025
@brooksprumo brooksprumo marked this pull request as ready for review July 23, 2025 04:46
@brooksprumo brooksprumo requested a review from HaoranYi July 23, 2025 04:46
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.2%. Comparing base (fa79971) to head (719ad3c).
⚠️ Report is 2833 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7096   +/-   ##
=======================================
  Coverage    83.2%    83.2%           
=======================================
  Files         854      854           
  Lines      374650   374649    -1     
=======================================
+ Hits       312046   312066   +20     
+ Misses      62604    62583   -21     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@brooksprumo brooksprumo merged commit 7032929 into anza-xyz:master Jul 23, 2025
41 checks passed
@brooksprumo brooksprumo deleted the lthash/div-ceil branch July 23, 2025 15:25
puhtaytow pushed a commit to puhtaytow/agave that referenced this pull request Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants