Update more blockstore.rs tests to use merkle shreds#6163
Merged
steviez merged 7 commits intoanza-xyz:masterfrom Jul 24, 2025
Merged
Update more blockstore.rs tests to use merkle shreds#6163steviez merged 7 commits intoanza-xyz:masterfrom
steviez merged 7 commits intoanza-xyz:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #6163 +/- ##
=========================================
- Coverage 83.3% 83.2% -0.1%
=========================================
Files 854 854
Lines 374597 374573 -24
=========================================
- Hits 312087 311992 -95
- Misses 62510 62581 +71 🚀 New features to boost your workflow:
|
steviez
reviewed
May 14, 2025
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
This one fell off my radar, but two quick comments:
- Can you give a more descriptive name than "fix more tests". Maybe something like "Update blockstore tests to use merkle shreds"
- I see you have updated two calls of
set_last_in_slot(). It looks like there are 6 in total; want to knock them all out in this PR and then we can tieset_last_in_slot()cleanup in as well
alexpyattaev
changed the title
alexpyattaev
force-pushed
the
blockstore_legacy
branch
from
d836db6 to
5e085e3
Compare
steviez
reviewed
Jul 23, 2025
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
Overall looks good, just the minor items I called out. Also, can you please rebase to tip of master ?
alexpyattaev
force-pushed
the
blockstore_legacy
branch
from
5e085e3 to
2f2b6f1
Compare
alexpyattaev
commented
Jul 23, 2025
steviez
approved these changes
Jul 24, 2025
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
LGTM, sorry again for such the long delay in reviewing this but there is some tricky stuff so glad we spent the time to properly dig in.
I'm going to merge this so I can rebase some of the subsequent PR's I have ready
puhtaytow
pushed a commit
to puhtaytow/agave
that referenced
this pull request
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Legacy shreds need to go #5982
Summary of Changes
Port more tests in blockstore.rs to merkle