Skip to content

perf: move benchmarks to bencher 0.1.5#7041

Merged
alexpyattaev merged 1 commit intoanza-xyz:masterfrom
puhtaytow:perf-bench-0
Jul 22, 2025
Merged

perf: move benchmarks to bencher 0.1.5#7041
alexpyattaev merged 1 commit intoanza-xyz:masterfrom
puhtaytow:perf-bench-0

Conversation

@puhtaytow
Copy link
Copy Markdown

Problem

Our benchmarking setup relies on nightly compiler which is not what we use for actual builds of agave. Using the same compiler (stable) for releases and benches would be preferable #5931

Summary of Changes

Moved benchmarks to bencher 0.1.5.

@mergify mergify Bot requested a review from a team July 18, 2025 19:35
@kskalski kskalski self-requested a review July 22, 2025 09:11
@kskalski kskalski requested a review from alexpyattaev July 22, 2025 10:19
Copy link
Copy Markdown

@alexpyattaev alexpyattaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexpyattaev alexpyattaev added the CI Pull Request is ready to enter CI label Jul 22, 2025
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Jul 22, 2025
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.2%. Comparing base (f5c84e3) to head (18f1024).
Report is 37 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7041   +/-   ##
=======================================
  Coverage    83.2%    83.2%           
=======================================
  Files         853      853           
  Lines      374698   374698           
=======================================
+ Hits       311796   311810   +14     
+ Misses      62902    62888   -14     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexpyattaev alexpyattaev merged commit f70c0ab into anza-xyz:master Jul 22, 2025
56 checks passed
@puhtaytow puhtaytow deleted the perf-bench-0 branch July 23, 2025 17:45
puhtaytow added a commit to puhtaytow/agave that referenced this pull request Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants