validator: Move SnapshotConfig parsing to separate function#7086
Merged
steviez merged 2 commits intoanza-xyz:masterfrom Jul 23, 2025
Merged
validator: Move SnapshotConfig parsing to separate function#7086steviez merged 2 commits intoanza-xyz:masterfrom
steviez merged 2 commits intoanza-xyz:masterfrom
Conversation
steviez
force-pushed
the
val_snap_cfg_parsing
branch
from
fe6d126 to
35b442a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7086 +/- ##
=======================================
Coverage 83.2% 83.2%
=======================================
Files 854 854
Lines 374653 374668 +15
=======================================
+ Hits 312058 312072 +14
- Misses 62595 62596 +1 🚀 New features to boost your workflow:
|
SnapshotConfig has a non-trivial amount of arguments, operations and checks that occur. Shift all of this logic into a side function to help organize and de-clutter
steviez
force-pushed
the
val_snap_cfg_parsing
branch
from
35b442a to
fc2ccd7
Compare
brooksprumo
reviewed
Jul 22, 2025
brooksprumo
approved these changes
Jul 23, 2025
brooksprumo
left a comment
brooksprumo
left a comment
There was a problem hiding this comment.
I copied the patch into an external diff tool and confirmed there were no functional changes.
puhtaytow
pushed a commit
to puhtaytow/agave
that referenced
this pull request
Jul 24, 2025
…#7086) SnapshotConfig has a non-trivial amount of arguments, operations and checks that occur. Shift all of this logic into a side function to help organize and de-clutter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #7085rebasedProblem
SnapshotConfig has a non-trivial amount of arguments, operations and checks that occur
Summary of Changes
Shift all of this logic into a side function to help declutter this function/file