Revert - The disabling of enable_stack_frame_gaps in bpf_account_data_direct_mapping#7056
Merged
Lichtso merged 2 commits intoanza-xyz:masterfrom Jul 23, 2025
Conversation
|
The Firedancer team maintains a line-for-line reimplementation of the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7056 +/- ##
=========================================
- Coverage 83.2% 83.2% -0.1%
=========================================
Files 853 853
Lines 374799 374799
=========================================
- Hits 311897 311892 -5
- Misses 62902 62907 +5 🚀 New features to boost your workflow:
|
LucasSte
reviewed
Jul 22, 2025
Comment on lines
+1363
to
+1364
| for i in 10..MAX_CALL_DEPTH / 2 { | ||
| let stack = &mut stack[i * STACK_FRAME_SIZE * 2..][..STACK_FRAME_SIZE]; |
There was a problem hiding this comment.
The maximum call depth shouldn't have changed.
| stack_frame_size: compute_budget.stack_frame_size, | ||
| enable_address_translation: true, | ||
| enable_stack_frame_gaps: !feature_set.bpf_account_data_direct_mapping, | ||
| enable_stack_frame_gaps: true, |
There was a problem hiding this comment.
Perhaps we can clean up this setting then.
Lichtso
force-pushed
the
revert/enable_stack_frame_gaps_in_bpf_account_data_direct_mapping
branch
from
df4fce0 to
28cc4d8
Compare
LucasSte
approved these changes
Jul 23, 2025
Lichtso
deleted the
revert/enable_stack_frame_gaps_in_bpf_account_data_direct_mapping
branch
puhtaytow
pushed a commit
to puhtaytow/agave
that referenced
this pull request
Jul 24, 2025
…ata_direct_mapping` (anza-xyz#7056) * Reverts the disabling of enable_stack_frame_gaps in bpf_account_data_direct_mapping. * Adjusts test_stack_heap_zeroed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the original direct mapping implementation it was necessary to disable stack frame gaps to avoid issues in memory accesses spanning over multiple regions. In the new direct mapping implementation memory accesses are restricted to a single region, thus we can revert this part of the feature gate back to the state it is when the feature is disabled. This way the stack behavior will only change when a program opts into SBPFv1.
Summary of Changes
Re-enables
enable_stack_frame_gapsin the SBPF VM.