Removes update_accounts_hash() family of fns#7091
Merged
brooksprumo merged 1 commit intoanza-xyz:masterfrom Jul 23, 2025
Merged
Removes update_accounts_hash() family of fns#7091brooksprumo merged 1 commit intoanza-xyz:masterfrom
brooksprumo merged 1 commit intoanza-xyz:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7091 +/- ##
========================================
Coverage 83.2% 83.2%
========================================
Files 854 854
Lines 374726 374380 -346
========================================
- Hits 312092 311813 -279
+ Misses 62634 62567 -67 🚀 New features to boost your workflow:
|
HaoranYi
reviewed
Jul 23, 2025
| /// This is intended to be used by startup verification, and also AccountsHashVerifier. | ||
| /// Uses account storage files as the data source for the calculation. | ||
| // obsolete, will be removed next | ||
| pub fn calculate_accounts_hash( |
HaoranYi
reviewed
Jul 23, 2025
| let bank_hash_stats = BankHashStats::default(); | ||
| let accounts_delta_hash = accounts_db.get_accounts_delta_hash(slot).unwrap(); | ||
| let accounts_hash = accounts_db.get_accounts_hash(slot).unwrap().0; | ||
| let accounts_hash = AccountsHash(Hash::default()); // obsolete, any value works |
roryharr
approved these changes
Jul 23, 2025
puhtaytow
pushed a commit
to puhtaytow/agave
that referenced
this pull request
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The merkle-based accounts hashing is no longer used.
Summary of Changes
This PR removes the AccountsDb
update_accounts_hash()family of functions.