Use Instruction instead of StableInstruction across runtime#7040
Merged
LucasSte merged 1 commit intoanza-xyz:masterfrom Jul 18, 2025
Merged
Use Instruction instead of StableInstruction across runtime#7040LucasSte merged 1 commit intoanza-xyz:masterfrom
Instruction instead of StableInstruction across runtime#7040LucasSte merged 1 commit intoanza-xyz:masterfrom
Conversation
Instruction instead of StableInstruction across runtime
|
The Firedancer team maintains a line-for-line reimplementation of the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7040 +/- ##
=======================================
Coverage 83.2% 83.2%
=======================================
Files 853 853
Lines 374864 374856 -8
=======================================
+ Hits 312074 312082 +8
+ Misses 62790 62774 -16 🚀 New features to boost your workflow:
|
Lichtso
approved these changes
Jul 18, 2025
puhtaytow
pushed a commit
to puhtaytow/agave
that referenced
this pull request
Jul 24, 2025
…-xyz#7040) Use Instruction instead of StableInstruction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The runtime code is very complex, containing multiple sites with similar code doing the same thing, many data structures to represent the same underlying data and too many conversions between them.
That conundrum hinders proper refactors for ABIv2 and the simplification of our runtime code.
Summary of Changes
This PR replaces
StableIntructionbyInstructionacross runtime, except in address translation, where the switch is not possible.That reduces the conversion overhead and will allow us to further simplify our code in future PRs.