Skip to content

net-utils: Resolve Rust 1.88 clippy lints and format strings#7045

Merged
steviez merged 2 commits intoanza-xyz:masterfrom
steviez:rust_1.88_net-utils
Jul 20, 2025
Merged

net-utils: Resolve Rust 1.88 clippy lints and format strings#7045
steviez merged 2 commits intoanza-xyz:masterfrom
steviez:rust_1.88_net-utils

Conversation

@steviez
Copy link
Copy Markdown

@steviez steviez commented Jul 18, 2025

Problem

Working towards #6850, broken out from #6854

Summary of Changes

  • Run cargo clippy --fix --tests with Rust 1.88.0 set in rust-toolchain.toml
    • These should only be instances of uninlined_format_args
  • Run cargo fmt with format_strings = true set in rustfmt.toml

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 36.11111% with 23 lines in your changes missing coverage. Please review.

Project coverage is 83.2%. Comparing base (c87ab7c) to head (8464b8d).

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #7045     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         853      853             
  Lines      374734   374743      +9     
=========================================
- Hits       311896   311831     -65     
- Misses      62838    62912     +74     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@alexpyattaev alexpyattaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steviez steviez merged commit 9f273bc into anza-xyz:master Jul 20, 2025
41 checks passed
@steviez steviez deleted the rust_1.88_net-utils branch July 20, 2025 23:11
puhtaytow pushed a commit to puhtaytow/agave that referenced this pull request Jul 24, 2025
…z#7045)

- Ran cargo clippy with Rust 1.88.0 set in rust-toolchain.toml
- Ran cargo fmt with format_strings = true in rustfmt.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants