scripts: remove obsolete cargo-fmt.sh#7036
Merged
joncinque merged 2 commits intoanza-xyz:masterfrom Jul 23, 2025
Merged
Conversation
|
Personally this change falls under the "surprising" category for me. This script, based on its name, clearly is meant to communicate "I'm calling I'd be more OK with a different script calling fmt and sort, but I don't think we should call sort here. |
|
Based on the discord convo here, seems like |
puhtaytow
changed the title
Author
😅 Thank you guys for taking action on this one. I'll follow #devops channel since now on. |
joncinque
approved these changes
Jul 23, 2025
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Looks good to me
Author
|
Thank you 🙏 |
puhtaytow
added a commit
to puhtaytow/agave
that referenced
this pull request
Jul 24, 2025
* add sort workspace to cargo fmt script * remove obsolete formatting script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As per #7036 (comment) this script is obsolete.
Summary of Changes
The
cargo-fmt.shis no more.