agave-validator: move tests#7078
Merged
yihau merged 6 commits intoanza-xyz:masterfrom Jul 23, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7078 +/- ##
=========================================
- Coverage 83.2% 83.2% -0.1%
=========================================
Files 854 854
Lines 374686 374686
=========================================
- Hits 312083 312059 -24
- Misses 62603 62627 +24 🚀 New features to boost your workflow:
|
steviez
approved these changes
Jul 22, 2025
steviez
left a comment
steviez
left a comment
There was a problem hiding this comment.
Works for me, and I assume all future PR's will follow this pattern too ?
Member
Author
|
yeah, I’ll keep the relevant arg tests in their respective modules 🫡 |
puhtaytow
pushed a commit
to puhtaytow/agave
that referenced
this pull request
Jul 24, 2025
* move verify_args_struct_by_command_run_with_no_genesis_fetch() * move verify_args_struct_by_command_run_with_no_snapshot_fetch * move verify_args_struct_by_command_run_with_check_vote_account * move verify_args_struct_by_command_run_with_only_known_rpc * move verify_args_struct_by_command_run_with_incremental_snapshot_fetch * wording
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
some tests are currently written in args.rs, but they can be moved to the corresponding modules for better organization
Summary of Changes
move them