metrics: move benchmarks to bencher 0.1.5#7011
Merged
alexpyattaev merged 2 commits intoanza-xyz:masterfrom Jul 20, 2025
Merged
Conversation
|
@kskalski or @alexpyattaev when you get a chance, can you take a look? |
kskalski
reviewed
Jul 17, 2025
| extern crate test; | ||
|
|
||
| use { | ||
| bencher::{benchmark_group, benchmark_main, black_box, Bencher}, |
There was a problem hiding this comment.
could we use std::hint::black_box ? might be a bit more future-ready
kskalski
approved these changes
Jul 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7011 +/- ##
=======================================
Coverage 83.2% 83.2%
=======================================
Files 853 853
Lines 375116 375116
=======================================
+ Hits 312225 312250 +25
+ Misses 62891 62866 -25 🚀 New features to boost your workflow:
|
puhtaytow
added a commit
to puhtaytow/agave
that referenced
this pull request
Jul 24, 2025
* move benchmarks to bencher 0.1.5 * use std::hint::black_box where possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Our benchmarking setup relies on nightly compiler which is not what we use for actual builds of agave. Using the same compiler (stable) for releases and benches would be preferable #5931
Summary of Changes
Moved benchmarks to bencher 0.1.5.