Merged
Conversation
Co-Authored-By: C-Lodder <lodder15@hotmail.co.uk>
The title attribute is generally not very accessible. Keyboard users and touch screen users will never see it. It is particularly useless to add a title which is the same as other text already present as that can result in a screen reader announcing the same text twice. This PR removes the redundant title attribute where the same text is already present.
The title attribute is generally not very accessible. Keyboard users and touch screen users will never see it. It is particularly useless to add a title which is the same as other text already present as that can result in a screen reader announcing the same text twice. This PR removes the redundant title attribute where the same text is already displayed and removes/replaces one language string where it wwas not needed NOTE this is just a first pass at removing the low hanging fruit and a further pr will be needed when the tooltips are reviewed
This pr removes the sidebar from all the views previously accessed (in J3) from the extensions menu. As in J4 they all have their own place in the system menu they can simply be removed Co-Authored-By: brianteeman <brian@teeman.net>
Co-Authored-By: hardik-codes <hardik06agarwal@gmail.com>
The title attribute is generally not very accessible. Keyboard users and touch screen users will never see it. It is particularly useless to add a title which is the same as other text already present as that can result in a screen reader announcing the same text twice. This PR removes the redundant title attribute from two fieldsets as the same text is correctly present in the fieldset legend
The title attribute is generally not very accessible. Keyboard users and touch screen users will never see it. It is particularly useless to add a title which is the same as other text already present as that can result in a screen reader announcing the same text twice. This PR removes the redundant title attribute where the same text is already displayed NOTE this is just a first pass at removing the low hanging fruit and a further pr will be needed when the tooltips are reviewed Co-Authored-By: brianteeman <brian@teeman.net>
The title attribute is generally not very accessible. Keyboard users and touch screen users will never see it. It is particularly useless to add a title which is the same as other text already present as that can result in a screen reader announcing the same text twice. This PR removes the redundant title attribute where the same text is already displayed. NOTE this is just a first pass at removing the low hanging fruit and a MUCH LARGER further pr will be needed when the tooltips are reviewed
When the only content of a tab is an editor there is no need to have the label displayed next to the editor instead it can be displayed above the editor. This is already the case for categories. This PR adds the same for tags and contacts (miscellaneous information)
Forgot to remove the `InstallerHelper::addSubmenu($vName);` from the controller for com_install
* [4.0] Date in example string The current string is > The date of birth entered should use the format Year-Month-Day, ie 0000-00-00 this PR uses a better example date to further clarify that it is YMD * eg
Remove some more unused strings from this language file
Final removal of remnants of magic quotes related code as magic quotes was completely removed in php 5.4 there can never be an instance when it will be triggered in j4
infograf768
pushed a commit
that referenced
this pull request
Mar 27, 2019
Add missing string COM_PRIVACY_MSG_CONSENT_NO_CONSENT
laoneo
pushed a commit
that referenced
this pull request
Apr 14, 2022
…oomla#36804) Fixes `Fixes `Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in libraries/src/Date/Date.php on line 112` error on login`
laoneo
pushed a commit
that referenced
this pull request
Apr 14, 2022
…ssing null to type string (joomla#36795) * [3.10] [PHP 8.1] fixes mod_tags_popular Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_tags_popular/mod_tags_popular.php on line 29` * [3.10] [PHP 8.1] fixes mod_breadcrumbs Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_breadcrumbs/mod_breadcrumbs.php on line 21` * Update mod_custom.php Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in modules/mod_custom/mod_custom.php on line 18` * [3.10] [PHP 8.1] Fixes mod_menu.php Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in modules/mod_menu/mod_menu.php on line 23` * [3.10] [PHP 8.1] mod_stats * [3.10] [PHP 8.1] fixes mod_articles_archive.php * [3.10] [PHP 8.1] mod_articles_categories.php * [3.10] [PHP 8.1] fixes mod_articles_category * [3.10] [PHP 8.1] fixes mod_articles_latest * [3.10] [PHP 8.1] fixes mod_articles_news * [3.10] [PHP 8.1] fixes mod_articles_popular * [3.10] [PHP 8.1] fixes mod_banners * [3.10] [PHP 8.1] fixes mod_feed * [3.10] [PHP 8.1] fixes mod_footer * [3.10] [PHP 8.1] fixes mod_languages * [3.10] [PHP 8.1] fixes mod_random_image * [3.10] [PHP 8.1] fixes mod_related_items * [3.10] [PHP 8.1] fixes mod_syndicate * [3.10] [PHP 8.1] fixes mod_tags_similar * [3.10] [PHP 8.1] fixes mod_users_latest * [3.10] [PHP 8.1] fixes mod_whosonline * [3.10] [PHP 8.1] fixes mod_wrapper * [3.10] [PHP 8.1] fixes admin mod_privacy_dashboard * [3.10] [PHP 8.1] fixes admin mod_feed * [3.10] [PHP 8.1] fixes admin mod_stats_admin
laoneo
pushed a commit
that referenced
this pull request
Apr 14, 2022
…tible (joomla#36794) * [3.10] [PHP 8.1] Make templates/system/html/modules.php PHP 8.1 compatible Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/system/html/modules.php on line 101` and a few more (line 35, line 53, line 115) * [3.10] [PHP 8.1] Fixes protostar modules.php null string param Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/templates/protostar/html/modules.php on line 47` * [3.10] [PHP 8.1] Fixes beez modules.php null string param Fixes errors like `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in templates/beez/html/modules.php on line 42`
laoneo
pushed a commit
that referenced
this pull request
Apr 14, 2022
…oomla#36799) Fixes `Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in /home/beat/www/j/libraries/src/Date/Date.php on line 112` error on login
laoneo
pushed a commit
that referenced
this pull request
Apr 14, 2022
Fixes `Deprecated: ucfirst(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/libraries/src/MVC/Controller/BaseController.php on line 286` and fixes `Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/libraries/src/MVC/Controller/BaseController.php on line 684`
laoneo
pushed a commit
that referenced
this pull request
Apr 14, 2022
…36777) * [3.10] [PHP 8.1] Fix Editor Passing null to $string line 258 Fixes `Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Editor/Editor.php on line 258` * [PHP 8.1] Editor in backend: Better fix for joomla#36777 Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
laoneo
pushed a commit
that referenced
this pull request
Apr 14, 2022
…oomla#36773) * [3.10] [PHP 8.1] Fixes mod_menu/menu.php type null instead of string Fixes Deprecated: trim(): `Passing null to parameter #1 ($string) of type string is deprecated in administrator/modules/mod_menu/menu.php on line 383` * [PHP 8.1] admin mod_menu: Slightly cleaner fix for joomla#36773
laoneo
pushed a commit
that referenced
this pull request
Apr 14, 2022
* [3.10] [PHP 8.1] Fixes com_finder/indexer/query Fixes `Deprecated: html_entity_decode(): Passing null to parameter #1 ($string) of type string is deprecated in administrator/components/com_finder/helpers/indexer/query.php on line 733` * Better fix for joomla#36796 as suggested by @zero-24
laoneo
pushed a commit
that referenced
this pull request
Apr 14, 2022
…strpos() (joomla#36798) * [3.10] [PHP 8.1] Fixes Router/Route.php deprecated null to string in strpos() Fixes `Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in libraries/src/Router/Route.php on line 124` * [PHP 8.1] Better fix to avoid deprecation proposed by @zero-24 Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> * Revert previous commit for different fix in mod_breadcrumbs/helper.php * [PHP 8.1] Better fix for joomla#36798 mod_breadcrumbs with null link in last item Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
laoneo
pushed a commit
that referenced
this pull request
Apr 14, 2022
… is deprecated in components/com_ajax/ajax.php on line 39 (joomla#37007) Fix Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in components/com_ajax/ajax.php on line 39
laoneo
pushed a commit
that referenced
this pull request
Apr 14, 2022
…src/Log/Log.php on line 387` (joomla#37009) Fixes `Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Log/Log.php on line 387`
Bodge-IT
pushed a commit
that referenced
this pull request
Jun 4, 2025
…of type string is deprecated (joomla#44876)
Bodge-IT
pushed a commit
that referenced
this pull request
Jun 4, 2025
PHP Deprecated: strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated Signed-off-by: BrianTeeman <brian@teeman.net>
Bodge-IT
pushed a commit
that referenced
this pull request
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to match base