[4.0] Fix disable and enable buttons#24276
Merged
wilsonge merged 12 commits intojoomla:4.0-devfrom Mar 21, 2019
maliouris:4.0-dev
Merged
[4.0] Fix disable and enable buttons#24276wilsonge merged 12 commits intojoomla:4.0-devfrom maliouris:4.0-dev
wilsonge merged 12 commits intojoomla:4.0-devfrom
maliouris:4.0-dev
Conversation
joomla-cms-bot
added
NPM Resource Changed
Member
|
Please solve conflicting file |
Member
|
@Fedik |
Member
|
yes that looks good 😉 |
Contributor
|
Awesome stuff! Thankyou very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Remove connectedCallback() call from the constructor as it might cause some issues later and moved a part of code from the costructor to the connectedCallback() function in order to disable buttons properly
Testing Instructions
Expected result
Actual result
Documentation Changes Required