[4.0] Remove sidebar from com_installer#24080
Conversation
This pr removes the sidebar from all the views previously accessed (in J3) from the extensions menu. As in J4 they all have their own place in the system menu they can simply be removed
|
Agree with this generally. Only question is do we need a back to system admin dashboard or are we happy with the browser back button? |
|
@wilsonge i did think about that but figured it was beyond the scope of this pr as the same comment could be made about a lot of the links from the dashboard and i kind of hoped the secret template group might have already addressed that |
|
@wilsonge Also I left the function addSubmenu in the code (but empty) I wasn't sure if it should be completely removed or not |
administrator/components/com_installer/View/Installer/HtmlView.php
Outdated
Show resolved
Hide resolved
….php Co-Authored-By: brianteeman <brian@teeman.net>
|
I have tested this item ✅ successfully on 673c791 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24080. |
|
I have tested this item ✅ successfully on 673c791 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24080. |
|
Status "Ready To Commit". |
Kill it. It serves no purpose anymore
They've not touched com_installer. Some of the works gone into the public repo. and most the rest has in the private repo has been on the admin menu, dashboard and login screens |
|
removed the function as requested |
|
Thanks! |
|
Thanks |
This pr removes the sidebar from all the views previously accessed (in J3) from the extensions menu.
As in J4 they all have their own place in the system dashboard they can simply be removed