Skip to content

[4.0] Remove sidebar from com_installer#24080

Merged
wilsonge merged 6 commits intojoomla:4.0-devfrom
brianteeman:extensions_sidebar
Mar 21, 2019
Merged

[4.0] Remove sidebar from com_installer#24080
wilsonge merged 6 commits intojoomla:4.0-devfrom
brianteeman:extensions_sidebar

Conversation

@brianteeman
Copy link
Contributor

This pr removes the sidebar from all the views previously accessed (in J3) from the extensions menu.

As in J4 they all have their own place in the system dashboard they can simply be removed

This pr removes the sidebar from all the views previously accessed (in J3) from the extensions menu.

As in J4 they all have their own place in the system menu they can simply be removed
@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Mar 4, 2019
@wilsonge
Copy link
Contributor

wilsonge commented Mar 4, 2019

Agree with this generally. Only question is do we need a back to system admin dashboard or are we happy with the browser back button?

@brianteeman
Copy link
Contributor Author

@wilsonge i did think about that but figured it was beyond the scope of this pr as the same comment could be made about a lot of the links from the dashboard and i kind of hoped the secret template group might have already addressed that

@brianteeman
Copy link
Contributor Author

@wilsonge Also I left the function addSubmenu in the code (but empty) I wasn't sure if it should be completely removed or not

….php

Co-Authored-By: brianteeman <brian@teeman.net>
@softforge
Copy link
Contributor

I have tested this item ✅ successfully on 673c791

Does as it says and removes the side menu in
Manage Extensions
Install Extensions
Update Extensions


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24080.

@Bodge-IT
Copy link
Contributor

Bodge-IT commented Mar 9, 2019

I have tested this item ✅ successfully on 673c791

Sidebar gone from extensions,discover & INSTALL LANG.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24080.

@ghost
Copy link

ghost commented Mar 9, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 9, 2019
@wilsonge
Copy link
Contributor

@wilsonge Also I left the function addSubmenu in the code (but empty) I wasn't sure if it should be completely removed or not

Kill it. It serves no purpose anymore

@wilsonge i did think about that but figured it was beyond the scope of this pr as the same comment could be made about a lot of the links from the dashboard and i kind of hoped the secret template group might have already addressed that

They've not touched com_installer. Some of the works gone into the public repo. and most the rest has in the private repo has been on the admin menu, dashboard and login screens

@brianteeman
Copy link
Contributor Author

removed the function as requested

@wilsonge wilsonge merged commit 444b843 into joomla:4.0-dev Mar 21, 2019
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 21, 2019
@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the extensions_sidebar branch March 21, 2019 13:17
@zero-24 zero-24 added this to the Joomla 4.0 milestone Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants