Skip to content

Conversation

@beat
Copy link
Contributor

@beat beat commented Jan 22, 2022

Pull Request for Issue # none

Summary of Changes

Fixes in all modules errors like:
Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_tags_popular/mod_tags_popular.php on line 29
Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_breadcrumbs/mod_breadcrumbs.php on line 21

Testing Instructions

View front-end and backend in PHP 8.1 while debug on and all PHP errors.

Actual result BEFORE applying this Pull Request

Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_tags_popular/mod_tags_popular.php on line 29
Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_breadcrumbs/mod_breadcrumbs.php on line 21

Expected result AFTER applying this Pull Request

No such warnings

Documentation Changes Required

None.

Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_tags_popular/mod_tags_popular.php on line 29`
beat added 24 commits January 23, 2022 00:47
Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/beat/www/j/modules/mod_breadcrumbs/mod_breadcrumbs.php on line 21`
Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in modules/mod_custom/mod_custom.php on line 18`
Fixes `Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in modules/mod_menu/mod_menu.php on line 23`
@beat beat changed the title [WIP]: [3.10] [PHP 8.1] fixes mod_tags_popular [3.10] [PHP 8.1] fixes all modules Deprecated: htmlspecialchars(): Passing null to type string Jan 23, 2022
@beat beat marked this pull request as ready for review January 23, 2022 00:16
@alikon alikon added the PHP 8.x PHP 8.x deprecated issues label Jan 23, 2022
@richard67
Copy link
Member

I have tested this item ✅ successfully on 9d216c5

Code review only, but that should be sufficient here if done well.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36795.

@zero-24 zero-24 added this to the Joomla 3.10.6 milestone Jan 23, 2022
@zero-24
Copy link
Contributor

zero-24 commented Jan 23, 2022

LGTM Thanks @beat

@zero-24 zero-24 merged commit e02d637 into joomla:3.10-dev Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PHP 8.x PHP 8.x deprecated issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants