Skip to content

[4.0] WebComponents not loading without media version#24301

Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom
SharkyKZ:j4/refreshAssets
Mar 22, 2019
Merged

[4.0] WebComponents not loading without media version#24301
wilsonge merged 2 commits intojoomla:4.0-devfrom
SharkyKZ:j4/refreshAssets

Conversation

@SharkyKZ
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

Adds a check for media version.

Testing Instructions

Enable System Debug in Global Configuration.
In System - Debug plugin set Refresh Assets to No.

Expected result

WebComponents loaded.

Actual result

JS error:

TypeError: script.src.match(...) is null 1 core.js:1098:26
	Joomla.WebComponents http://localhost/40my/media/system/js/core.js:1098:26

Documentation Changes Required

No.

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Mar 22, 2019
@wilsonge wilsonge merged commit 9f934a3 into joomla:4.0-dev Mar 22, 2019
@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants